Repository navigation
Fix Codex borrow observations and cancellation - #268
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first live acceptance of the unified console exposed two observation errors: prepared HTTP forwarding restored the caller context and lost the transient borrow marker, and read-ahead cancellation after a valid completed stream made diagnostics report failure. The original HTTP responses contained completed terminals and visible
OKoutput.read_error. Missing terminals, upstream errors, and incomplete output still fail.Validation: regression coverage passes for completed streams with trailing cancellation, missing terminal events, actual borrowed-cookie counters, changed/missing cookies, and terminal ordering. Existing failed/incomplete Pelican cases still pass. The queued/in-flight cancellation regression and a deterministic parent-cancellation propagation-gap case pass without weakening the original no-dispatch assertion. Vue typecheck and focused lint passed; the CI race selection now includes the HTTP completion/dispatch regression. The existing production diagnostic ledger has used 9 of the authorized maximum 20 requests; only affected HTTP combinations will be rechecked after deployment, with the remaining budget enforced.