Repository navigation
Dokumentations- und Codebereinigung - #7
Merged
Merged
Conversation
SchlumpfSoft.GeometryNET.ThreeDimensional in der README-Beispielanwendung importiert und doppelte Beispielzeilen für Berechnungen sowie Console.WriteLine-Ausgaben entfernt.
Projektdatei-Paket-Tag auf Trapezoid korrigiert und README-Kompatibilitätsangaben präzisiert (.NET Framework 4.8.1, .NET 8/9/10 Windows-spezifisch).
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation example is consistent and references valid APIs.
0 open findings
What changed in this PR
Cleans the VB.NET quick-start example for consistent, directly usable geometry calls.
Changes:
- Removes duplicate console output statements.
- Normalizes the rectangle and sphere declarations.
| File | Description |
|---|---|
README.md |
Cleans duplicate lines in the usage example. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Classification
Dokumentations- und Codebereinigung: Das README-Beispiel wurde korrigiert, damit
Sphere.Volume(...)direkt im Beispiel verwendbar ist.PR Summary
Das PR bereinigt das README-Beispiel für die 3D-Geometrie und ergänzt den fehlenden Import für den direkten Zugriff auf
Sphere.Volume(...). Zusätzlich wurden doppelte bzw. fehlerhafte Zeilen im Codeblock entfernt, um das Beispiel konsistent und lauffähig zu machen.README.md: ImportSchlumpfSoft.GeometryNET.ThreeDimensionalergänzt und fehlerhafte/doppelte Codezeilen im Beispiel bereinigt.