Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Skills → Browse can offer Install for a skill already discovered on disk.
Clicking it then fails with “Already installed”.
This change shows direct GitHub catalog entries as Installed when their
destination folder matches a discovered Claude skill. It reuses the
installer's URL parsing and folder validation, existing button styling,
and existing translation.
Matching uses folder identity rather than frontmatter names, so unrelated
skills with the same display name remain installable. OpenCode and Codex
plugins are excluded. Unresolved third-party catalog links are outside
this change's scope.
Addresses #793.
Type of change
Evidence
The images below show actual test output rendered as images, not
screenshots of a running Electron app. Both runs use the same component
test and fixtures.
Before
On unchanged source, an already-installed skill showed:
The six-case component suite had 5 passes and 1 failure.
After
With the patch, the same skill showed:
The same six-case suite had 6 passes and 0 failures.
How I tested it
Windows, Node.js 24.16.0:
npm run typecheck— passed.npm run build— passed.npm run test:focused— 940 passed, 23 failed, 14 skipped.For comparison, the unchanged baseline at f797048 had 928 passed,
23 failed, and 14 skipped. The same 23 test names and error types
occurred in both runs; all 12 newly added tests passed. The failures
include Windows file-symlink permission errors, worktree dependency
tests, and unrelated source/configuration assertions.
Checklist
npm run typecheckpasses.npm run test:focusedpasses — baseline failures documented above.npm run buildsucceeds.