Skip to content

fix(resample): reject a non-finite to_grid rate #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ayam04 wants to merge 1 commit into from
Closed

fix(resample): reject a non-finite to_grid rate #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/hflow/resample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

import numpy as np

from hflow._field_guards import require_finite_float
from hflow.format import NANOSECONDS_PER_SECOND

if TYPE_CHECKING:
Expand Down Expand Up @@ -238,6 +239,7 @@ def to_grid(
pinned by ``hflow.format.RESAMPLE_POLICY_VERSION`` (see the module
docstring).
"""
rate_hz = require_finite_float(rate_hz, "rate_hz")
if rate_hz <= 0.0:
raise ValueError(f"rate_hz must be positive, got {rate_hz}")
source_columns = _source_columns(channel, field)
Expand Down
16 changes: 13 additions & 3 deletions tests/test_resample_derive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,19 @@ def test_to_grid_rejects_span_shorter_than_one_step() -> None:
to_grid(ramp_channel(), 0.01, policy="interpolate")


def test_to_grid_rejects_nonpositive_rate() -> None:
with pytest.raises(ValueError, match="rate_hz must be positive"):
to_grid(ramp_channel(), 0.0, policy="interpolate")
@pytest.mark.parametrize(
("rate_hz", "message"),
[
(0.0, "rate_hz must be positive"),
(-1.0, "rate_hz must be positive"),
(float("nan"), "rate_hz must be finite"),
(float("inf"), "rate_hz must be finite"),
(float("-inf"), "rate_hz must be finite"),
],
)
def test_to_grid_requires_a_finite_positive_rate(rate_hz: float, message: str) -> None:
with pytest.raises(ValueError, match=message):
to_grid(ramp_channel(), rate_hz, policy="interpolate")


def test_derived_series_validates_column_lengths() -> None:
Expand Down
Loading