Repository navigation
fix(lerobot): bound episode PTS and scope v3 export - #745
Open
victorwon2001 wants to merge 1 commit into
Open
victorwon2001 wants to merge 1 commit into
victorwon2001 wants to merge 1 commit into
Conversation
Contributor
[Medium impact] This PR appears safe to merge; no actionable issues were found.
|
kstonekuan
requested changes
Oct 29, 2026
kstonekuan
left a comment
Contributor
There was a problem hiding this comment.
Could you change Fixes #742 to Refs #742? The report also covers repeated --episode-index values, image-only input errors, and the hardcoded workflow manifest; those remain after this fix.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #742 by tightening the LeRobot video PTS lower-bound tolerance to half a frame and limiting v3 export conversion to the source episodes in the selection. Insufficient video-window PTS packet errors now include the episode index, camera, and metadata time window.
Why
Float quantization could include the prior episode's final frame at the start boundary. Exporting a small selection also converted every source episode, allowing a corrupt unselected episode to block export.
Validation
uv run pytest -q tests/test_lerobot_converter.py tests/test_lerobot_export.py— 108 passed.uv run pytest -q tests/test_lerobot_workflow.py— 3 passed.uv run ruff check src/hflow/importers/lerobot.py examples/lerobot/export.py examples/lerobot/workflow.py tests/test_lerobot_converter.py tests/test_lerobot_export.py— passed.uv run ruff format --check src/hflow/importers/lerobot.py examples/lerobot/export.py examples/lerobot/workflow.py tests/test_lerobot_converter.py tests/test_lerobot_export.py— passed.uv run ty check— passed.uv run pytest -q— 2 failed, 2611 passed, 8 skipped. The cache migration test fails independently becauseffprobeis not copied; a DuckDB resource-in-use failure in one converter test passed when rerun alone.Checklist
uv run ruff check --fix,uv run ruff format, anduv run ty check.Need help on this PR? Tag
@codesmith-botwith what you need.