Repository navigation
fix(snapshot): reject non-object format markers (#746) - #747
Merged
kstonekuan merged 1 commit intoOct 29, 2026
Merged
kstonekuan merged 1 commit into
kstonekuan merged 1 commit into
Conversation
Contributor
[Low impact] The PR appears safe to merge.
|
kstonekuan
approved these changes
Oct 29, 2026
kstonekuan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix. Ruff, ty, the snapshot regressions, and both Python CI jobs pass. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format.jsonbefore accessing its fields.2instead of anAttributeErrortraceback.null, arrays, strings, and numbers.Why
Valid JSON does not necessarily contain a valid snapshot marker. Previously, a non-object root caused
hflow verify snapshotto crash with an unhandled exception.Validation
uv run pytest -q -n 4— 2,615 passed, 8 skippeduv run pytest -q tests/test_snapshot_verify.py— 41 passeduv run ruff check— passeduv run ruff format --check— passeduv run ty check— passedCloses #746
Need help on this PR? Tag
@codesmith-botwith what you need.