Show consent checkmark only when consent is granted and await its animation before navigating - #3071
Merged
StylianosGakis merged 3 commits intoAug 20, 2026
Conversation
…mation before navigating The analytics-consent step's green checkmark used to pop in a second after the screen appeared, regardless of what the member had chosen. It now reflects the stored analytics consent: shown from the first frame when consent was already granted, hidden otherwise, and animated in or out when the member allows or denies. When the decision flips the checkmark, the step waits for the pop to finish before advancing: the card reports the visibility it settled on and the presenter holds navigation until that report arrives. A decision that leaves the checkmark as it was advances immediately. All routes off the screen now go through a single pending-navigation state, so the allow/deny buttons disable while a decision is in flight and repeated taps can only ever produce one navigation.
StylianosGakis
marked this pull request as ready for review
August 20, 2026 07:40
panasetskaya
approved these changes
Aug 20, 2026
The pendingNavigation latch had no release. Since continueFrom leaves the consent entry on the back stack and the presenter is WhileSubscribed, coming back re-subscribed the same presenter with the latch still set, so buttonsEnabled stayed false and the step could not be completed. Release the latch after the navigation completes, keeping it held for the whole in-flight window including the checkmark animation wait. This matches the phone step, which resets its submitting state for the same reason. Also re-derive the checkmark from stored consent before the Content early return, and seed it from lastState, so a presenter that restarts while this screen is showing does not drop a granted member's checkmark. The repeated-decisions test no longer sends a decision after the navigation has happened, which is a tap on an entry sitting behind another one and cannot be delivered. The burst assertion that covers the actual requirement is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a11y