Repository navigation
Stop cancelled chat runs at frame and graph-write boundaries - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An analyst could press Stop after a completed tool and still get later graph writes and next-stage progress. Returning from the inner step did not stop its caller; even a delay-level cancellation check left a microtask gap before the graph update.
The existing shared step now checks immediately before its synchronous graph callback, and every emitted frame uses one guarded snapshot. Pending waits cancel their timer and listener. Earlier results remain available and Retry completes normally. Source tours and the developer walkthrough now explain and link to these boundaries; their generator preserves the existing Stop/Retry guidance. Model-refresh PR #15 has no overlapping files.
Validation:
0d6b9380fd947b75165433dcc6a6372b11c54b5e86232b083208d34c7cb6f4e0; adapter SHA256 is961078dc9a127169232e23175b551bb632ccd7af6daac88045b00f9161976d4c.Limits: full local prepush and provider calls were not run. CI checks this exact PR head separately. Five affected development dependencies covering seven advisories and the existing large-bundle warning remain outside this repair. The generated chat template has a separate cancellation pattern for follow-up. This publishes source changes; no hosted app deployment is claimed.