Skip to content

fix(deps): bump undici to 8.11.2 to clear the high production advisory - #257

Closed
HomenShum wants to merge 1 commit into
mainfrom
claude/undici-8.10.2
Closed

HomenShum wants to merge 1 commit into
mainfrom
claude/undici-8.10.2

Conversation

@HomenShum

@HomenShum HomenShum commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

What changes

The direct dependency undici goes from ^8.10.0 (locked at 8.10.0) to ^8.11.2 (locked at 8.11.2). The lockfile was regenerated with npm install --package-lock-only --ignore-scripts, and only the undici entries change: 2 files, 5 lines.

Why

Both verify jobs run npm audit --omit=dev --audit-level=moderate first. It failed on undici 8.0.0–8.10.1 (high), so typecheck, tests and build never ran. That blocked unrelated work, including #256. 8.11.2 is inside the app's existing ^8.10.0 range and keeps the same node >=22.19.0 engine.

Evidence (local, same command as CI)

before (main) after
npm audit --omit=dev --audit-level=moderate exit 1 0
high 1 0
moderate 0 0
low 11 11

The 11 low advisories are below the gate's threshold and are not addressed here. They need their own assessment before anyone claims a zero-vulnerability audit.

Not verified locally

Typecheck, tests and build were not run locally. This PR exists so CI can reach them for the first time since the advisory landed.

🤖 Generated with Claude Code

Current automatic CI evidence — 2026-10-07

Both automatic PR CI and push CI verify that the production audit proceeds with 11 low findings and no moderate/high findings after this version update. Their installation summaries still report 18 total findings (11 low, 4 moderate, 3 high); this is not a zero-vulnerability result.

The next terminal blocker is proofs:staleness: docs/eval/noderoom-fresh-user-vertical-proof.json is 38.7 days old against its 30-day window. CI requests a new proof batch or withdrawal of the associated claim. Fresh-room verification, SLO, typechecks, tests and build are downstream of this failure and did not run. This PR remains open pending honest freshness evidence and the remaining configured checks.

Superseded by PR256 — 2026-10-09

Closing this PR as a superseded source change consolidates the active review in PR256. Its current head c8789df42a425f6d101ecfac8e29a0cfa4b06eb9 contains the complete, byte-identical package.json and package-lock.json blobs from this PR's unchanged head 9ca232963afaa445a0a10d50940a5a6286049365, together with the README onboarding update and a substantive before/after production-gate changelog. Neither of this PR's two changed files contains remaining unique work.

This is source supersession, not a merge of the donor commit or a green-CI certificate. The donor branch claude/undici-8.10.2, its head/history, and the original dated evidence above are retained; this closure does not move or delete any branch ref.

The earlier donor CI still failed at the fresh-user proof's measured age of 38.7 days versus a 30-day window. The replacement's tested dependency amendment f2a759 improved the production-only audit from 12 findings (11 low, 1 high) to 11 low findings, while its PR CI failed at proof age 40.2 days and its push CI failed changed-area commit checking. The separate installation audit still reported 18 findings (11 low, 4 moderate, 3 high). These remain historical failures; no proof date, freshness policy, checker or authentication requirement has been reset or waived.

Source equality does not establish current-head CI, fresh-room proof, SLO, typechecks, tests, build, production or merge readiness. Those remaining obligations continue in PR256 with their own exact-head evidence. The original paragraph saying this PR remained open describes its earlier dated state; this supersession note records the later consolidation decision.

npm audit --omit=dev --audit-level=moderate failed on undici 8.0.0-8.10.1
(high), which stopped both verify jobs before typecheck, tests and build.
Lock regenerated with --package-lock-only; only the undici entries change.
After: 0 high, 0 moderate, 11 low (below the gate's moderate threshold).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
noderoom Ready Ready Preview Oct 7, 2026 5:09pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Scaffold Handoff — For Your Coding Agent

Your coding agent (Codex, Claude Code, etc.) should apply the accepted
scaffold proposals below. Do NOT touch any immutable files.

Immutability Check

Mode: advisory

✅ No immutable files were modified in this branch.

Changed Files

  • docs/eval/OFFICIAL_BENCHMARK_READINESS.md
  • docs/eval/OFFICIAL_BENCHMARK_TASK_COVERAGE.md
  • docs/eval/OPENROUTER_CONVEX_BENCHMARK.md
  • docs/eval/agent-improvement-loop.md
  • docs/eval/agent-improvement-loop.svg
  • docs/eval/agent-improvement-loop/20261007T170951Z.json
  • docs/eval/agent-improvement-loop/latest.json
  • docs/eval/agent-workspace-sandbox-smoke.json
  • docs/eval/algorithm-artifact-smoke.json
  • docs/eval/bankertoolbench-official-contract.json
  • docs/eval/docker-sandbox-probe.json
  • docs/eval/eval-runs.jsonl
  • docs/eval/halo-convex-context-telemetry.json
  • docs/eval/halo-self-improvement-smoke.json
  • docs/eval/halo-variant-selection.json
  • docs/eval/official-benchmark-readiness.json
  • docs/eval/official-benchmark-task-coverage.json
  • docs/eval/openrouter-convex-benchmark.json
  • docs/eval/professional-catalog-proofs.json
  • docs/eval/professional-proof-ledger.json
  • docs/eval/spreadsheetbench-chart-visual-probe.json
  • docs/eval/traces/credit/20261007T170958643Z-c2956b4e_dirty.1c314d930a687254/cascade-healthy.json
  • docs/eval/traces/credit/20261007T170958643Z-c2956b4e_dirty.1c314d930a687254/delta-incomplete.json
  • docs/eval/traces/credit/20261007T170958643Z-c2956b4e_dirty.1c314d930a687254/mapping-correct.json
  • docs/eval/traces/credit/20261007T170958643Z-c2956b4e_dirty.1c314d930a687254/mapping-misbind.json
  • docs/eval/traces/credit/20261007T170958643Z-c2956b4e_dirty.1c314d930a687254/summit-stressed.json
  • docs/eval/traces/ladder/20261007T170958287Z-c2956b4e_dirty.b7e2704f212fe4bb/ladder_L1_read_scripted.json
  • docs/eval/traces/ladder/20261007T170958287Z-c2956b4e_dirty.b7e2704f212fe4bb/ladder_L2_edit_scripted.json
  • docs/eval/traces/ladder/20261007T170958287Z-c2956b4e_dirty.b7e2704f212fe4bb/ladder_L3_conflict_scripted.json
  • docs/eval/traces/ladder/20261007T170958287Z-c2956b4e_dirty.b7e2704f212fe4bb/ladder_L4_blocked_scripted.json
  • docs/eval/traces/ladder/20261007T170958287Z-c2956b4e_dirty.b7e2704f212fe4bb/ladder_L5_large_range_scripted.json
  • docs/eval/traces/ladder/20261007T170958287Z-c2956b4e_dirty.b7e2704f212fe4bb/ladder_L6_long_horizon_scripted.json
  • docs/eval/traces/ladder/20261007T170958287Z-c2956b4e_dirty.b7e2704f212fe4bb/ladder_L7_resume_scripted.json
  • package-lock.json
  • package.json

Needs Adversarial Review — Do NOT Apply Yet

These proposals passed the reject check but have not been approved by
an adversarial reviewer. A human or frozen LLM judge must approve them first.

  • scaf-001 (AGENTS.md): Add explicit instruction for step spreadsheetbench-runner-fixture: Step spreadsheetbench-runner-fixture failed — scaffold may need explicit instruction or evidence assertion.
  • scaf-002 (AGENTS.md): Add explicit instruction for step convex-boundaries: Step convex-boundaries failed — scaffold may need explicit instruction or evidence assertion.

Safety Boundary

Agent may improve the scaffold.
Agent may NOT weaken the proof gate.

Immutable files (never modify):

  • scripts/proofloop.mjs
  • scripts/agent-improvement-loop.ts
  • tests/harnessChangeEval.test.ts
  • .github/workflows/
  • src/eval/evalTrustPolicy.ts
  • src/eval/architectureBudget.ts
  • evals/evalStore.ts

Scaffold files (safe to modify):

  • AGENTS.md
  • CLAUDE.md
  • proofloop/scenarios/*.yaml
  • proofloop/rubrics/*.yaml
  • proofloop/subagents/*.md
  • proofloop/adapters/*.js
  • .proofloop/memory.jsonl
  • src/nodeagent/models/prompts/systemPrompt.ts

This branch was successfully deployed

1 active deployment
Preview — 9ca23296 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant