Skip to content

fix(evals): reject unconfigured real-mode runs - #260

Draft
HomenShum wants to merge 1 commit into
mainfrom
codex/eval-mode-truth-20261014
Draft

HomenShum wants to merge 1 commit into
mainfrom
codex/eval-mode-truth-20261014

Conversation

@HomenShum

@HomenShum HomenShum commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

npm run eval:real without an Anthropic key silently executed scripted golden plans, printed anthropic (real) and SCORE: 6/6 passed, and exited successfully. Reject missing, empty or whitespace-only keys before cases, the banner or scoring, and use the same model selector for single-turn, multi-turn and property cases. Deliberate npm run eval remains scripted even when credentials are configured.

Eight scenario tests cover actual CLI rejection, offline replay, locally intercepted real-model routing, constructor failure, repeated runs and concurrent jobs. The old runner fails five tests; the repair passes all eight. Existing golden cases and scorers are unchanged and still pass 6/6. No provider request or genuine model-quality claim.

The normal local full floor passes both typechecks and 2,787 tests, with one failure: the existing marketed live-product receipt is 45.6 days old against its 30-day freshness window. The same failure reproduces on unchanged main. Two earlier worker-only Excel COM failures pass in the normal parent environment. Raw failures are retained; this PR does not change the receipt timestamp, freshness policy or test.

This stays draft until the repository gate and exact-head CI are green. The additional QA-memory line records only a limited read-only entry-page diagnostic, with authenticated/provider journeys explicitly skipped and no whole-app score. No visual-source or model-refresh changes, production deployment, paid evaluations or automatic promotion.

Independent gpt-6-astra/xhigh code and simplification review approved the bounded five-file patch, SHA-256 db5e653776eeb89b8e75122c4091f1f217acd51ffa6c5bb0bf45a0ce4c8651fd, tree f34c73edac0fceef8191a444d2fccb8f10ae01c9. The reviewer reran eight scenarios and actual-CLI Unicode-whitespace/configured-offline probes, inspected all 45 implementation evidence files, and separately marked repository readiness blocked by the stale-proof gate. Its alternate test-pool run is supplementary evidence, not a replacement for the canonical floor.

Current CI also stops at the earlier production dependency audit: run38571197209 reports12 affected packages (11low,1high) from unchanged main dependency files. Existing PR256 already contains the Undici repair, so this eval-mode PR does not duplicate it. The audit and expired live-product receipt are separate merge blockers; all later unreached CI stages remain uncertified.

evals: fail before scoring when real mode has no non-blank Anthropic key and share model selection across every case shape.
tests: exercise configuration failures, offline replay, intercepted real routing, repeated sessions and concurrent CLI jobs.
docs: state the real-mode precondition and scripted evidence boundary.
CHANGELOG: record before/after behavior and retained repository gate failures.
.qa: append the limited read-only entry diagnostic with unverified journeys explicitly skipped.

Verification: eight mode scenarios pass (five fail on the old runner); unchanged golden cases pass 6/6. Both typechecks and 2,787 tests pass in the normal local floor; its one failure is the unchanged expired marketed proof. Independent code and simplification review approve the exact patch; merge readiness remains blocked.
@vercel

vercel Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
noderoom Ready Ready Preview Oct 14, 2026 1:23pm UTC

Request Review

@github-actions

Copy link
Copy Markdown

Scaffold Handoff — For Your Coding Agent

Your coding agent (Codex, Claude Code, etc.) should apply the accepted
scaffold proposals below. Do NOT touch any immutable files.

Immutability Check

Mode: advisory

✅ No immutable files were modified in this branch.

Changed Files

  • .qa/memory/runs.jsonl
  • CHANGELOG/qa/eval-mode-truth.md
  • docs/AGENT_EVAL.md
  • docs/eval/OFFICIAL_BENCHMARK_READINESS.md
  • docs/eval/OFFICIAL_BENCHMARK_TASK_COVERAGE.md
  • docs/eval/OPENROUTER_CONVEX_BENCHMARK.md
  • docs/eval/agent-improvement-loop.md
  • docs/eval/agent-improvement-loop.svg
  • docs/eval/agent-improvement-loop/20261014T132302Z.json
  • docs/eval/agent-improvement-loop/latest.json
  • docs/eval/agent-workspace-sandbox-smoke.json
  • docs/eval/algorithm-artifact-smoke.json
  • docs/eval/bankertoolbench-official-contract.json
  • docs/eval/docker-sandbox-probe.json
  • docs/eval/eval-runs.jsonl
  • docs/eval/halo-convex-context-telemetry.json
  • docs/eval/halo-self-improvement-smoke.json
  • docs/eval/halo-variant-selection.json
  • docs/eval/official-benchmark-readiness.json
  • docs/eval/official-benchmark-task-coverage.json
  • docs/eval/openrouter-convex-benchmark.json
  • docs/eval/professional-catalog-proofs.json
  • docs/eval/professional-proof-ledger.json
  • docs/eval/spreadsheetbench-chart-visual-probe.json
  • docs/eval/traces/credit/20261014T132311288Z-d42bb1e8_dirty.424969c487bbf91b/cascade-healthy.json
  • docs/eval/traces/credit/20261014T132311288Z-d42bb1e8_dirty.424969c487bbf91b/delta-incomplete.json
  • docs/eval/traces/credit/20261014T132311288Z-d42bb1e8_dirty.424969c487bbf91b/mapping-correct.json
  • docs/eval/traces/credit/20261014T132311288Z-d42bb1e8_dirty.424969c487bbf91b/mapping-misbind.json
  • docs/eval/traces/credit/20261014T132311288Z-d42bb1e8_dirty.424969c487bbf91b/summit-stressed.json
  • docs/eval/traces/ladder/20261014T132310805Z-d42bb1e8_dirty.29aedb28a1e0e04c/ladder_L1_read_scripted.json
  • docs/eval/traces/ladder/20261014T132310805Z-d42bb1e8_dirty.29aedb28a1e0e04c/ladder_L2_edit_scripted.json
  • docs/eval/traces/ladder/20261014T132310805Z-d42bb1e8_dirty.29aedb28a1e0e04c/ladder_L3_conflict_scripted.json
  • docs/eval/traces/ladder/20261014T132310805Z-d42bb1e8_dirty.29aedb28a1e0e04c/ladder_L4_blocked_scripted.json
  • docs/eval/traces/ladder/20261014T132310805Z-d42bb1e8_dirty.29aedb28a1e0e04c/ladder_L5_large_range_scripted.json
  • docs/eval/traces/ladder/20261014T132310805Z-d42bb1e8_dirty.29aedb28a1e0e04c/ladder_L6_long_horizon_scripted.json
  • docs/eval/traces/ladder/20261014T132310805Z-d42bb1e8_dirty.29aedb28a1e0e04c/ladder_L7_resume_scripted.json
  • evals/runEval.ts
  • tests/runEvalMode.test.ts

Needs Adversarial Review — Do NOT Apply Yet

These proposals passed the reject check but have not been approved by
an adversarial reviewer. A human or frozen LLM judge must approve them first.

  • scaf-001 (AGENTS.md): Add explicit instruction for step spreadsheetbench-runner-fixture: Step spreadsheetbench-runner-fixture failed — scaffold may need explicit instruction or evidence assertion.
  • scaf-002 (AGENTS.md): Add explicit instruction for step convex-boundaries: Step convex-boundaries failed — scaffold may need explicit instruction or evidence assertion.

Safety Boundary

Agent may improve the scaffold.
Agent may NOT weaken the proof gate.

Immutable files (never modify):

  • scripts/proofloop.mjs
  • scripts/agent-improvement-loop.ts
  • tests/harnessChangeEval.test.ts
  • .github/workflows/
  • src/eval/evalTrustPolicy.ts
  • src/eval/architectureBudget.ts
  • evals/evalStore.ts

Scaffold files (safe to modify):

  • AGENTS.md
  • CLAUDE.md
  • proofloop/scenarios/*.yaml
  • proofloop/rubrics/*.yaml
  • proofloop/subagents/*.md
  • proofloop/adapters/*.js
  • .proofloop/memory.jsonl
  • src/nodeagent/models/prompts/systemPrompt.ts

This branch was successfully deployed

1 active deployment
Preview — 3e07ae60 Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant