Skip to content

ci: restore C++ CodeQL analysis (dynamic workflow is python-only since 2026-08-08) - #664

Closed
mvillmow wants to merge 2 commits into
mainfrom
655-auto-impl
Closed

mvillmow wants to merge 2 commits into
mainfrom
655-auto-impl

Conversation

@mvillmow

Copy link
Copy Markdown
Collaborator

Summary

Implements the requested changes for issue #655.

Changes

See the PR diff for the full change set.

Testing

Not run by the automation pipeline.

Closes

Closes #655

Generated by Hephaestus automation

Move the CodeQL job out of _required.yml into a new codeql.yml workflow and update the workflows README accordingly.

Closes #655

Implemented-By: OpenCode
Co-Authored-By: OpenCode-AI <4211002+mvillmow@users.noreply.github.com>
Signed-off-by: Micah Villmow <4211002+mvillmow@users.noreply.github.com>
Comment thread .github/workflows/codeql.yml
fix(automation): request valid gh pr checks --json fields

Closes #655

Implemented-By: OpenCode
Co-Authored-By: OpenCode-AI <4211002+mvillmow@users.noreply.github.com>
Signed-off-by: Micah Villmow <4211002+mvillmow@users.noreply.github.com>
@mvillmow

mvillmow commented Aug 24, 2026 •

Copy link
Copy Markdown
Collaborator Author

Automated PR review

Total grade: A

Review summary: Reviewer validated the implementation responses to all open threads.

Eligibility is represented only by the live GitHub implementation-state label; this audit comment is informational.

Reviewed head: 6f4d422bb6ea9e5e0c7dc335f1a180305105883f.

@mvillmow
mvillmow added this pull request to the merge queue Aug 25, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 25, 2026
@mvillmow
mvillmow added this pull request to the merge queue Aug 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 27, 2026
@mvillmow
mvillmow added this pull request to the merge queue Aug 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 28, 2026
@mvillmow
mvillmow added this pull request to the merge queue Sep 13, 2026
@mvillmow
mvillmow removed this pull request from the merge queue due to a manual request Sep 13, 2026
@mvillmow
mvillmow enabled auto-merge September 13, 2026 19:13
@mvillmow

Copy link
Copy Markdown
Collaborator Author

Closing as superseded

C++ CodeQL analysis was already restored on main by a different approach, so this PR and that fix are mutually exclusive.

What landed instead

Commit 0232e1b — "fix(codeql): restore C++ analysis + de-static Google Benchmark functions (#657)" — restored C++ analysis inside the existing required workflow rather than extracting it into a new one:

  • .github/workflows/_required.yml:1008 — # Restored from the deleted workflow (c-cpp manual build + python).
  • .github/workflows/_required.yml:1023 — - language: c-cpp in the analysis matrix
  • .github/workflows/_required.yml:1040-1048 — the C++ manual build steps, gated on matrix.language == 'c-cpp'

main's Analyze (c-cpp/python) check reports success.

Why this conflicts

This PR takes the opposite structural approach: it adds .github/workflows/codeql.yml as a standalone workflow and removes the analyze job from _required.yml. Applying it would undo #657 and drop the check out of the required set — which is exactly the regression #657 was written to fix (see 79e8e0e, "consolidate all workflows into _required.yml so every job is a required check via the homeric-main-baseline ruleset").

Only one of the two designs can hold, and #657's is the one currently merged and enforced by the ruleset.

Related

#661 is a duplicate of this PR — same title, same goal, same approach (adds .github/workflows/codeql.yml). Both are closed together; see #661 for the matching comment.

Verified against origin/main at the time of closing.

@mvillmow mvillmow closed this Sep 14, 2026
auto-merge was automatically disabled September 14, 2026 00:39

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: restore C++ CodeQL analysis (dynamic workflow is python-only since 2026-08-08)

1 participant