Repository navigation
fix(runtime): preserve the complete advisory response contract (#30) - #347
Merged
Merged
Conversation
HouMinXi
force-pushed
the
fix/30-runtime-reply-keys-20261101
branch
from
November 1, 2026 16:13
f9f8643 to
d711f15
Compare
HouMinXi
marked this pull request as ready for review
November 1, 2026 17:25
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #30.
The consumer validation already delivered by #59 remains unchanged. This does not manufacture smoke receipts or convergence evidence.
Validation
Tests replace provider/HTTP or subprocess boundaries; no live provider calls or native CLI service were required. This is not a claim that the entire repository test suite passed. Formal CE automation was not run.
CI follow-up
The first Linux run reported three legacy CLI test doubles that did not accept the new opt-in keyword (31,522 tests passed). The follow-up only updates those test doubles, asserts the default remains false, and adds an explicit runtime strict-true forwarding assertion. Production code is unchanged by the follow-up. New-head CI is green at
f9f8643f48ba41c2d555fc2adedee4fb05b2097e: Linux tests, changed-file lint and CodeQL all succeeded. The service-free selection passed 31,526 tests (81 skipped, 68 deselected), ownership/cancellation passed 568, cgroup sandbox passed 32, and local process integration passed 11. These counts retain the workflow's existing selection/exclusions, not an assertion that every repository test ran.Attribution-clean CI and final composition
Current head
d711f15deef9772452da14791855c3fb09def97chas terminal-green Linux, lint, and CodeQL. Linux checked this head against main8493df4: 31,944 service-free tests passed (81 skipped, 64 deselected), plus 568 ownership/cancellation, 32 sandbox and 11 integration cases passed. The older SHA above is historical before the authorized attribution rewrite.Prospective composition with #353 is clean: 28 disjoint changed paths retain their reviewed source blobs; 2,094 focused combined tests passed with no failures or skips. Full Ruff check/format (789 files), whitespace and independent composition/requirements acceptance pass. No denied real-CLI/Semgrep qualification route was run. Expected merge tree for this PR:
e9745b18b7d7e77fd9855ebc54d6afd81dcafd1c; expected tree after #353:a649d8acf41985fbab743db4ae376005d91c0b73.Final merged-main CI
Both approved PRs are merged. Final main
2141c997494d08a6756d7073c5dcb1397fc48deehas the reviewed composition treea649d8acf41985fbab743db4ae376005d91c0b73; Linux tests and CodeQL are terminal green. Linux logs confirm this exact checkout: 32,010 service-free cases passed (81 skipped, 64 deselected; 2 subtests), 568 ownership/cancellation, 32 sandbox, and 11 integration cases passed (7 deselected). These selections may overlap and are not summed. Both merged feature branches were deleted and their absence verified. No CI source fix or history rewrite was needed for this merge sequence.