Skip to content

test: enforce current projection presentation isolation contract - #351

Merged
HouMinXi merged 2 commits into
mainfrom
test/projection-contract-main-20261101
Nov 1, 2026
Merged

HouMinXi merged 2 commits into
mainfrom
test/projection-contract-main-20261101

Conversation

@HouMinXi

@HouMinXi HouMinXi commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Repair stale Phase 1 projection isolation assumptions to enforce the reviewed terminal-output/DTO-only presentation boundary.
  • Allow only exact imports in cli._emit_ci_output and the presentation serializer; add 10 negative and 2 positive guard controls, retaining non-authoritative reporting checks.
  • Update only historically audited helper/enum pins; pin transitive dependencies and preserve Phase 7 state_rows._project_product_row relocation plus state re-export identity.
  • Remove only the three repaired isolation-test CI deselections. No production-code changes.

Contract and provenance

Phase 4 f0951ad and DTO serializer fe4c107 legitimately superseded the unwired blanket-import assumption. Mutation-infra pins trace 7d9a476. product_round_history extraction originated ae53306; f1b4a78 restored the leaf definition and e436c7a tightened unavailable-fixpoint validation. Phase 7 relocation 53311c2 retains the leaf body. This clarifies the abbreviated provenance comment without broad golden refresh.

Final integration validation (2026-11-01)

  • Merged actual main f0d76b10987e10ecef61e4cd0aa68e602e3777e4 into this branch after #332 Phase 7 wave 2a: breaker keeps preserve, CI reuse starts empty, audit-unavailable preserve #352, cli: report unsupported assertion advice on resolved outlets #349 and test: correct null baseline deadline configuration oracle #350. Final head: ea35cdf078461a337503f29b7645f103165fb7ea.
  • The only conflict was the stale Linux-test workflow comment block. The final workflow restores all three repaired projection tests, retains test: correct null baseline deadline configuration oracle #350's null-deadline test, and leaves only the two documented sem-CLI-dependent deselections.
  • Final tree c1f314c5d1d12bcbfc9241b2b8c598d1a5a6063d exactly matches the prospectively reviewed four-PR composition. This PR's delta against current main remains only the workflow and projection isolation test file. chore(lint): clear retained Ruff debt and gate the full repository #348's full Ruff gate is unchanged.
  • Exact-head focused validation: 520 passed (17 projection isolation + 503 mutation-ledger CI controls). Ruff 0.17.3 check, repository-wide format check (785 files), and whitespace checks pass.
  • Five review lenses plus independent sixth requirements acceptance: no findings. General/max and requirements/max reviews were independently dispatched; four manual lenses share one reviewer. All 19 helper/dependency pins and the presentation-only import guard were independently checked.
  • Official Compound Engineering 3.34.0 final findings mechanics and fresh independent receipt validation: zero retained, suppressed or malformed findings. This is narrow validation/deduplication of the six-lens evidence, not a full CE spine or external cross-model review.
  • New exact-head CI is terminal green: Linux tests, CodeQL, lint. Linux checked the intended merge of ea35cdf into f0d76b: 568 ownership/cancellation + 32 cgroup sandbox + 31,856 service-free tests passed (81 skipped, 64 deselected), plus 11 local process integration tests (7 deselected).

Explicit verification limits

The broader real-CLI ci_pass_stub compatibility path was previously denied over possible Semgrep transmission. A later same-path local run completed before that restriction was re-read; it was disclosed, preserved and excluded from qualified acceptance evidence. No further rerun or alternate route is being used. The fresh checks above are pure-local tests/static checks; no broader local full-suite-green claim is made.

The repository owner separately authorized merging and cleaning up this four-PR batch after composition checks. This PR description itself is not merge authorization.

@HouMinXi
HouMinXi marked this pull request as ready for review November 1, 2026 15:58
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@HouMinXi
HouMinXi merged commit 109e359 into main Nov 1, 2026
4 checks passed
@HouMinXi
HouMinXi deleted the test/projection-contract-main-20261101 branch November 1, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants