fix(s3): prevent per-shard client and cache growth - #87
Open
durson wants to merge 1 commit into
Open
Conversation
Reuse aiobotocore clients per process and S3 configuration instead of creating a retained client context for every shard. Reset inherited client state in DataLoader workers so clients remain tied to the worker event loop. Bound FileReader's async range cache to a configurable per-reader memory budget and expose presigned retry count for tail-latency tuning. Preserve the previous default of four total presigned request attempts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse aiobotocore clients per process and S3 configuration instead of creating a retained client context for every shard. Reset inherited client state in DataLoader workers so clients remain tied to the worker event loop.
Bound FileReader's async range cache to a configurable per-reader memory budget and expose presigned retry count for tail-latency tuning. Preserve the previous default of four total presigned request attempts.
Added env vars: