Repository navigation
Enable notification support for the chat messages - #181
Open
vikasbolla wants to merge 1 commit into
Open
vikasbolla wants to merge 1 commit into
vikasbolla wants to merge 1 commit into
Conversation
Signed-off-by: Vikas <vikas.satyanarayana.bolla@ibm.com>
anshuman-agarwala
left a comment
Member
There was a problem hiding this comment.
Added minor comments.
Overall LGTM
Comment on lines
+517
to
+519
| ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second) | ||
| defer cancel() | ||
| _ = ctx // reserved for future DB calls in this function |
Member
There was a problem hiding this comment.
Can this be removed? Seems like it's doing nothing.
We can add a context later if it's required.
Comment on lines
+511
to
+513
| // notifyUserOfAdminReply sends an email to the user every time an admin | ||
| // replies. There is no rate-limit on the user direction: the user may not be | ||
| // watching the UI and every reply deserves a nudge. |
Member
There was a problem hiding this comment.
Will this function spam users even if they have the chat window open?
If so we need to add the same chatNotifyQuietHours check we have for admin notifications.
Member
|
On an side note, do you think having an issue to unify logging throughout the project makes sense? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend
New event types (models/events.go)
New DB methods (db/interface.go, db/mongodb/chat.go)
SendGrid fixes (notifier/client/mail/mail.go)
Fixed HTTP 400: admin-only events (NotifyAdmin=true, Notify=false) now use AddTos instead of AddBCCs — SendGrid rejects BCC-only messages
Fixed content-type: "text" → "text/plain"
Notify() now returns an error on non-202 responses instead of ignoring it
MarkEventAsNotified is now only called when Notify succeeds — failed sends are retried on the next poll cycle instead of being permanently lost
Frontend
Timestamp display (components/ChatSupport.jsx, components/ChatAdmin.jsx)
How it works end-to-end