ci: cap release build artifact retention at 1 day - #5
Open
pmudry wants to merge 1 commit into
Open
Conversation
The windows and linux release jobs each uploaded a build artifact with the default 90-day retention, while publishing the very same files from desktop/dist to the GitHub Release in the following step. Releases do not count against the org Actions storage quota but artifacts do, so these duplicates accumulated 3.2 GB across 27 artifacts and exhausted the org-wide 2 GB quota, breaking artifact upload in unrelated repositories. The artifacts are still produced so that manual workflow_dispatch runs (where the release step is skipped) remain downloadable, but they now expire after a day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the org-wide Actions storage quota being exhausted, which broke
upload-artifactin unrelated repos (dc-iscGitHub Pages deploys were failing withArtifact storage quota has been hit).Why
Both release jobs upload a build artifact with the default 90-day retention, then publish the same files from
desktop/distto the GitHub Release in the very next step:desktop/dist/ISCSteam*.exe,latest.yml,*.blockmapdesktop/dist/ISCSteam*.AppImage,latest-linux.ymlRelease assets do not count against the org Actions storage quota, but artifacts do. This repo had accumulated 3.2 GB across 27 live artifacts — the single largest consumer in ISC-HEI, against a 2 GB org-wide quota on the Team plan.
Those 27 artifacts have already been deleted; this change stops them coming back (~350 MB per tagged release).
What
retention-days: 1on bothupload-artifactsteps. The artifacts are still produced, so manualworkflow_dispatchruns — where the release step is skipped byif: startsWith(github.ref, refs/tags/)— stay downloadable for debugging. They just no longer linger for 90 days.No change to release publishing: every asset users download is untouched.
Note for the reviewer
If a 1-day window is too tight for debugging a dispatch build over a weekend,
retention-days: 7is a one-word change and still cuts storage by ~92% versus the default.A stricter alternative, if you would rather these never accrue on tagged builds, is to skip the upload entirely when a release is being published:
I did not apply that here to keep the diff minimal.