Repository navigation
[bugfix] [test] update WCPB prelude frontier in split-prefill graph test - #154
Merged
bjf-frz merged 1 commit intoOct 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required human contributor answers
1. What outcome are you trying to achieve?
Update the stale WCPB prelude-frontier assertion in the existing split-prefill
CUDA Graph test so it validates the intended contract instead of failing before
the Graph branch.
2. What is the highest-leverage variable for that outcome?
The correctness of the test expectation for the WCPB prelude frontier relative
to the scheduler contract.
3. How will this work move that variable rather than create busywork?
A one-line test-only assertion update, followed by the full eager and CUDA Graph
capture/replay run. No production behavior changes.
4. Who is the customer or user, and what do they actually need?
Maintainers and future developers who rely on this regression test need it to
exercise the real Graph path rather than fail on a stale expectation.
PR necessity and bugfix evidence
A separate test-only PR is needed because the existing test assertion predates
WCPB. @LyxWxj confirmed that
num_preluded_tokens == 4is intended here: withtotal_ut_steps=4,prefill_chunk_size=2and a 4-token budget, one WCPB preludebatch stages both chunks.
num_prefilled_tokensremains 0 because the finalrecurrent depth has not completed.
The previous assertion
== 2is stale for WCPB. This PR does not changevllm_rlt/and is independent of M7 #153.Test Plan
28085c6onfix/wcpb-split-prefill-graph-assertion8fbf4cdruff 0.13.2
Test Result
tests/test_split_prefill.py -m "not gpu"The test now reaches and completes its CUDA Graph capture/replay portion.