Repository navigation
refactor: Add delete button string to common - #871
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing the ContactCard resource breaks its non-transitive R API without a compatibility path or documented migration.
2 open findings
What changed in this PR
Moves the localized delete-button label from ContactCard into Common and updates ContactCard usages.
Changes:
- Adds
deleteButtonto Common in all supported locales. - Removes duplicate ContactCard translations.
- Updates three Compose components to reference Common resources.
| File | Description |
|---|---|
Common/src/main/res/values/strings.xml |
Adds English delete label. |
Common/src/main/res/values-da/strings.xml |
Adds Danish delete label. |
Common/src/main/res/values-de/strings.xml |
Adds German delete label. |
Common/src/main/res/values-el/strings.xml |
Adds Greek delete label. |
Common/src/main/res/values-es/strings.xml |
Adds Spanish delete label. |
Common/src/main/res/values-fi/strings.xml |
Adds Finnish delete label. |
Common/src/main/res/values-fr/strings.xml |
Adds French delete label. |
Common/src/main/res/values-it/strings.xml |
Adds Italian delete label. |
Common/src/main/res/values-nb/strings.xml |
Adds Norwegian delete label. |
Common/src/main/res/values-nl/strings.xml |
Adds Dutch delete label. |
Common/src/main/res/values-pl/strings.xml |
Adds Polish delete label. |
Common/src/main/res/values-pt/strings.xml |
Adds Portuguese delete label. |
Common/src/main/res/values-sv/strings.xml |
Adds Swedish delete label. |
Ui/Compose/ContactCard/src/main/res/values/strings.xml |
Removes the local English label. |
Ui/Compose/ContactCard/src/main/res/values-da/strings.xml |
Removes the local Danish label. |
Ui/Compose/ContactCard/src/main/res/values-de/strings.xml |
Removes the local German label. |
Ui/Compose/ContactCard/src/main/res/values-el/strings.xml |
Removes the local Greek label. |
Ui/Compose/ContactCard/src/main/res/values-es/strings.xml |
Removes the local Spanish label. |
Ui/Compose/ContactCard/src/main/res/values-fi/strings.xml |
Removes the local Finnish label. |
Ui/Compose/ContactCard/src/main/res/values-fr/strings.xml |
Removes the local French label. |
Ui/Compose/ContactCard/src/main/res/values-it/strings.xml |
Removes the local Italian label. |
Ui/Compose/ContactCard/src/main/res/values-nb/strings.xml |
Removes the local Norwegian label. |
Ui/Compose/ContactCard/src/main/res/values-nl/strings.xml |
Removes the local Dutch label. |
Ui/Compose/ContactCard/src/main/res/values-pl/strings.xml |
Removes the local Polish label. |
Ui/Compose/ContactCard/src/main/res/values-pt/strings.xml |
Removes the local Portuguese label. |
Ui/Compose/ContactCard/src/main/res/values-sv/strings.xml |
Removes the local Swedish label. |
Ui/Compose/ContactCard/src/main/kotlin/com/infomaniak/core/ui/compose/contactcard/component/PreviewActionsBottomSheet.kt |
Uses the Common delete label. |
Ui/Compose/ContactCard/src/main/kotlin/com/infomaniak/core/ui/compose/contactcard/component/EditorContent.kt |
Uses Common for delete accessibility text. |
Ui/Compose/ContactCard/src/main/kotlin/com/infomaniak/core/ui/compose/contactcard/component/DefaultContactCardDialog.kt |
Uses Common for confirmation text. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LunarX
approved these changes
Oct 12, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.