Repository navigation
Add regression coverage for Shared With Me file lookup collisions - #2089
Closed
FabianDevel with Copilot wants to merge 2 commits into
Closed
FabianDevel with Copilot wants to merge 2 commits into
FabianDevel with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: FabianDevel <45429131+FabianDevel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code as per review comment
Add regression coverage for Shared With Me file lookup collisions
Sep 18, 2026
|
FabianDevel
removed this pull request from stack #2090
September 18, 2026 10:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Adds the missing regression coverage requested in review for
FileController.getFileByUidOrId. The new test locks in correct behavior when Shared With Me entries share the sameidacross different drives, while preserving the null-userDriveID lookup fallback.Regression scenario
Filerecords with the sameidand differentdriveId/uidvalues.Fallback coverage
idfile in the default realm.getFileByUidOrId(fileId)still resolves via plainFile::idwhen nouserDriveis provided.Test placement
app/src/androidTest/java/com/infomaniak/drive/data/cache/FileControllerTest.kt.