[Copilot]

The file details and file sharing screens always hit the /access endpoint, even for files the user has no sharing rights on, producing failing/useless requests. Mirrors the iOS fix in Infomaniak/ios-kDrive#2035.

Changes

• FileDetailsFragment: wraps the getFileShare(fileId) observer in a rights?.canShare == true check on the fetched file details.
• FileShareDetailsFragment: extracts the share fetching from refreshUi() into a private getFileShare(), invoked only when file.rights?.canShare == true. Share link retrieval (getShareLink) stays unconditional, so direct navigation to this screen for a non-shareable file still renders without the /access call.

if (fileResponse?.rights?.canShare == true) {
    mainViewModel.getFileShare(fileId).observe(viewLifecycleOwner) { shareResponse ->
        shareResponse.data?.let { fileDetailsViewModel.currentFileShare.value = it }
    }
}

Rights.canShare is a non-null Boolean, so == true only guards against a null rights object.

[Copilot]

Copilot review overview

🟡 Changes recommended

Share-link retrieval is incorrectly guarded despite the stated requirement that it remain unconditional.

Review effort: Balanced
Findings: 1

Open (1)

• Keep share-link retrieval unconditional for non-shareable files · New

What changed in this PR

Guards /access requests for files without sharing rights.

Changes:

• Checks canShare before fetching file-sharing details.
• Extracts share retrieval into a helper.

File	Description
FileDetailsFragment.kt	Guards share-detail retrieval.
FileShareDetailsFragment.kt	Separates and guards share retrieval.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud