[Rag-tools] create WS - #475
Open
Luc-Ank wants to merge 13 commits into
Open
Conversation
parmentf
requested changes
Sep 1, 2026
| # des appels en parallèle) — contrairement à vectorize.py, il ne s'agit pas | ||
| # d'un batch envoyé en un seul appel API, mais de N appels individuels | ||
| # exécutés en parallèle au sein du lot. | ||
| BATCH_SIZE = 32 |
Contributor
There was a problem hiding this comment.
🤔 thought (non-blocking): Le LLM qui m'aide à faire la review est perplexe (et j'avoue ne pas avoir un avis tranché):
pas de contrôle de rate-limit côté client
L'appel API distant n'a que MAX_RETRIES = 4 avec backoff exponentiel. Si le rate-limit est constant, on va spammer l'API avec 8 workers × BATCH_SIZE=32. Une implémentation de token bucket ou un ThreadPoolExecutor avec Semaphore serait plus prudent.
Comment on lines
+2
to
+4
| post.responses.default.description = Rag | ||
| post.responses.default.content.application/json.schema.$ref = #/components/schemas/JSONStream | ||
| post.summary = Rag |
Contributor
There was a problem hiding this comment.
✨ polish: summaries et descriptions d'un mot (« Rag ») — peu utiles dans swagger.
À développer.
Co-authored-by: François Parmentier <francois.parmentier@gmail.com>
Co-authored-by: François Parmentier <francois.parmentier@gmail.com>
Co-authored-by: François Parmentier <francois.parmentier@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.