Repository navigation
Fix/input and priority fixes - #349
Merged
Merged
Conversation
- The drag shares the node with the input button and showed the hand cursor, it shows the I-beam cursor now - Measure the masked text for the password input, the cursor was stuck at the end of the text - The arrow keys and the modificator keys are handled by the inner input, remove the duplicated handling
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #349 +/- ##
===========================================
+ Coverage 72.85% 73.60% +0.74%
===========================================
Files 31 31
Lines 4704 4773 +69
===========================================
+ Hits 3427 3513 +86
+ Misses 1277 1260 -17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The delete-key setting registration and Rich Input cursor synchronization still need to be addressed.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR improves input editing, cursor handling, Rich Input behavior, component priority resets, and drag interactions.
Changes:
- Adds navigation, modifiers, forward delete, and focus cleanup.
- Updates cursor styles and disabled drag behavior.
- Fixes priority propagation and updates tests and documentation.
| File | Summary |
|---|---|
wiki/changelog.md |
Documents changes and migration notes |
wiki/advanced-setup.md |
Documents delete-key configuration |
test/tests/test_input.lua |
Tests input behavior |
test/tests/test_component.lua |
Tests component priorities |
test/test.gui_script |
Registers component tests |
druid/styles/default/style.lua |
Adds default input cursors |
druid/extended/input.lua |
Implements input editing and cursor behavior |
druid/custom/rich_input/rich_input.lua |
Updates Rich Input integration |
druid/const.lua |
Adds delete-key configuration |
druid/component.lua |
Fixes priority propagation and reset |
druid/base/drag.lua |
Handles disabled drag cursors |
api/components/custom/rich_input_api.md |
Updates Rich Input API documentation |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+209
to
+210
| self.drag.style.ON_HOVER_CURSOR = self.input.style.ON_HOVER_CURSOR | ||
| self.drag.style.ON_MOUSE_HOVER_CURSOR = self.input.style.ON_MOUSE_HOVER_CURSOR |
…till mouse - Druid instance replays the last mouse move at the end of the update, if a component requested it with the internal `refresh_mouse()` - Scroll requests it once per frame, if the content moved: by the wheel, the inertion, the drag or the scroll_to animation - Hover resets the mouse hover when the mouse move is consumed by a component above - Button does not reset the hover on the mouse wheel or key actions consumed above - Remove the empty cursor stack entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.