Repository navigation
fix: address the review of the contribution routes - #46
Merged
Merged
Conversation
- titles and commit subjects neutralise @mentions, #refs, GH-n, owner/repo#n, closing keywords and URLs from reader text - GET /v1/contributions keeps only pull requests whose body ends with the exact identity marker, which reader text cannot produce - labelling is best effort once the pull request exists, so a failure no longer returns an error that invites a duplicate - failures after the branch is created delete it, leaving no orphan contribute/* branch - the link check follows redirects by hand, re-validating every hop as a public https address (at most 3), and is capped at 50 a day per identity - quota keys are case-insensitive, so slots are released whatever the repository's case; the release needs the marker on the last line - the daily slot is reserved before GitHub and given back on failure; KV's non-atomic counters are documented - a GitHub-side stale sha returns 409 with the current content, as the contract says - JSON bodies are read as a stream and abandoned once over the limit - spec: contributions list open, closed and merged Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes from an independent review of #41–#44 (the reviewer ran
npm run checktoo).fixes #12closed issue #12 on merge (title and commit subject were not escaped)neutralizeGitHubTexton titles and commit subjects:@,#n,GH-n,owner/repo#n, closing keywords, URLsGET /v1/contributionslisted other people's PRs whose text contained the marker words<is escaped)labelled: false)contentandshacontribute/*branchesELI5
A second review found ten loose ends in the new API, including a way to close our issues from a suggestion's name; all are tied up and each has a test.
Tests
npm run check: lint ✓, typecheck ✓, 411 tests ✓ (review-regressions.test.tscovers every row above).AI disclosure
Stacked on #44.
🤖 Generated with Claude Code