Upgrade to uniffi 0.32.0, support zero copy bytes - #64
Conversation
coltfred
left a comment
There was a problem hiding this comment.
fully_qualified_type_label needs a Type::Set arm so that the set type is fully qualified.
I added a test that fails currently. If you'd like to test it some other way, I'm good with that. Just wanted to show it broke
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 991a66f |
|
@coltfred fixed and also split Checked the output before and after for test files and its the same both ways. Should be all good now. |
This is a breaking change for by ref bytes from
byte[]toByteBuffer, and to the config setup. See the CHANGELOG for more info.A lot of the churn in this PR is due to upgrading Askama to 0.16.0 to match upstream.
Benches showed the zero-copy byte path is 3 to 20x faster than what we had before, so we'll likely make a breaking
ironcore-alloyrelease to switch the API over to them (in addition to the benefit that provides direct Rust callers).