ci(security): block on findings; mark the public Mapbox token

.github/workflows/build-publish.yml

@@ -79,7 +79,7 @@
       contents: read
     # The App key is a secret of the `release` environment; environment
     # secrets reach a reusable workflow only through `secrets: inherit`.
-    secrets: inherit # zizmor: ignore[secrets-inherit]
+    secrets: inherit # zizmor: ignore[secrets-inherit] # nosemgrep: yaml.github-actions.security.secrets-inherit.secrets-inherit
     with:
       version-file: package.json
       tag-prefix: ""

.github/workflows/security.yml

@@ -2,9 +2,10 @@
 # dependencies (osv-scanner on package-lock.json), semgrep, configuration and
 # licences.
 #
-# Report-only for now (fail-on empty): the report job lists every finding;
-# blocking follows once they are fixed. Accepted findings go into
-# .trivyignore.yaml / security/vex.openvex.json / .gitleaks.toml with a reason.
+# Blocking: a secret, a critical or high vulnerability with a fix, a high
+# misconfiguration, a forbidden licence or a semgrep error fails the check.
+# Accepted findings go into .trivyignore.yaml / security/vex.openvex.json /
+# .gitleaks.toml with a reason and an expiry date.
 name: security
 
 on:
@@ -30,4 +31,4 @@ jobs:
       security-events: write
     with:
       languages: node
-      fail-on: ""
+      fail-on: secrets,vuln-critical,vuln-high,misconfig-high,license-forbidden,semgrep-error

src/widget-mapbox.ts

@@ -51,6 +51,7 @@ type AppliedLayers = {
 // Fallback only: the IronFlock UI passes the token for its environment through `accessToken`.
 // This production token is URL-restricted to studio.ironflock.com.
 const DEFAULT_ACCESS_TOKEN =
+    // nosemgrep: generic.secrets.security.detected-jwt-token.detected-jwt-token -- a public Mapbox token (pk.), sent to every browser
     'pk.eyJ1IjoibWFya29wZSIsImEiOiJjbXB2Yjh2ankwMWUxMnNyM243aGFlNGxiIn0.BXax9rCajgo3Sn5MvAu7dQ'
 const DEFAULT_STYLE = 'light-v11'
 const LAYER_TYPES: LayerType[] = ['circle', 'symbol', 'heatmap', 'line']