Repository navigation
fix(appimage): restore portable offline Linux bundles for v1.9.0 - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Linux AppImage can fail catalog registration and ordinary-user startup because its metadata links point into the CI checkout, its launcher is not world-executable, RPATH rewriting corrupts the appended pkg server payload, and its glibc requirements exceed the catalog's Ubuntu 22.04 host. Installed Markdown parsing and offline graph layout also fail because the worker resolver omits installed filenames and the simulation worker downloads D3 externally.
This PR fixes those six failures and prepares v1.9.0 for publication:
PATCHELFboundary. Skip only--set-rpathfor the exact source-hash-matching server, forward queries and other files, and check the finished AppImage's stored permissions, metadata, icon and byte-identical server before upload.markdown-worker/markdown-worker.exenames while preserving override/build-name precedence, and load the existing bundled D3 for offline force/DAG layout.--versionbefore resource-pack preparation. The upstream executable's embedded signature bindsGodot.app'sInfo.plist; copying it out of the app otherwise causesSIGKILLandinvalid Info.plistdespite unchanged bytes. The upstream archive and source app remain unchanged.app_handle.package_info().versioninstead of the hardcodedv1.6.0. Tauri supplies the configured application version (1.9.0); no additional version constant or fallback is introduced.v1.9.0 (release date: 2026-10-05 UTC) also ships 125 upstream commits since v1.8.0; the release notes describe that broader product scope. Four test assumptions exposed by full regression are corrected: upload completion before teardown, native resource-root fixtures, direct Windows-style reference normalization, and valid zero-millisecond durations. These test corrections do not change production behavior.
Test plan
NOTE_CONNECTION_TAURI_TEST_STRICT=1 npm run test:tauri -- --locked, 34 passed, 0 failed, 1 existing ignored mobile cross-host probe, 0 filtered. The strict command exited 0.Godot.apppasses, all five standalone-copy cases reproduce the signature/startup failure, and all five separately signed controls pass strict signature verification and Python/Node launch probes.ff749c2559974c36e5c7f3bb30faf00ee5887fb4.verify:appimageexit 0). AppImage SHA-256:1ac08976a86f77ba9e45005c30de7379b870c97a3cc103e760540703177519c3. Packaged server and same-build original server are byte-identical, SHA-256:59b8bfebc2d059e1c53097bf43bf328da992e9ae2b66213a6003aebb12c7bdcf.2026-10-05T02:36:11Z; QEMU/control sockets were gone and the VM disk was retained.Linux end-to-end evidence, Windows/macOS build results and the macOS sidecar diagnosis have separate scopes; the latter two do not establish full desktop GUI acceptance. No Android APK/AAB is included without signing and device acceptance. Earlier diagnostic observations include reader/outline placeholders, Mermaid/DAG label presentation issues, and runtime metadata/extraction caches remaining after application exit; hardware GPU/audio and large-corpus performance are outside these packaging checks.
Verification attachments: Linux KVM validation summary and screenshots, SHA256SUMS.txt, source-validation.json and public-ci-manifest.json.