Repository navigation
Ensure no temp leaks - #19
Merged
Merged
Conversation
…mp file gets deleted
pgodden-jisc
approved these changes
Oct 14, 2026
pgodden-jisc
left a comment
pgodden-jisc
left a comment
Contributor
There was a problem hiding this comment.
Approved. I mentioned that the exceptions might be too broad but I talked myself out of that. The changes will clean up the tmp dir as we go which should keep the directory at a reasonable size. The MWAA workers can then cleanup the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of small fixes to help ensure that temporary files are always deleted when processing data, particularly when extraction processes fail, as its possible these can accumulate e.g. on Airflow, and cause temp space problems.