Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compressor Edge rejects some iPhone Dolby Vision videos before Media3 can attempt decoding. The source preflight requires a decoder advertising the exact
video/dolby-visionMIME type, overlooking compatible HEVC base-layer decoding.Let Media3 inspect Dolby Vision profiles and select a compatible decoder instead of blocking these inputs upfront. Preserve the original input metadata and retain the existing preflight for other source codecs. Unsupported Dolby Vision profiles can still fail through Media3's normal error handling.
Adds regression tests for Dolby Vision reaching output planning without an advertised decoder and unsupported HEVC retaining its decoder error. Enables Android resources in unit tests so the planner's localized errors can be checked.
Validation:
bash gradlew :app:assembleDebug :app:testDebugUnitTestwith JDK 21: passed, 36 tests.Equivalent fix for Compressor: JoshAtticus/Compressor#135. These PRs target independent apps and have no merge-order dependency.
Model: GPT-6.1 Sol | Harness: Codex in T3 Code