Repository navigation
Name a from_generator cache by a given fingerprint alone, as in Python - #112
Merged
Merged
Conversation
Forward a user-given `fingerprint` to `datasets`' own keyword instead of hashing it with `features` and `split`, so Julia and Python code calling `from_generator` with the same `fingerprint`, `cache_dir` and `split` share one cache. Also date the 0.4.4 changelog section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dataset(stream; fingerprint, cache_dir)/Dataset.from_generator(...; fingerprint)hashed the fingerprint together withfeaturesandsplit(generator/default-<hash>/), while Python'sfrom_generatornames the cache by the fingerprint alone (generator/default-fingerprint=<fp>/). So Julia and Python code with the same fingerprint built separate, identical caches.A given
fingerprintnow goes todatasets' own keyword, so both share one cache (as long as thesplitmatches, as in Python). The content-hash path for Julia sources is unchanged. Datasets cached under afingerprintby 0.4.4 are rebuilt once.Also dates the
[0.4.4]changelog section, which the release commit missed, and opens[0.4.5].🤖 Generated with Claude Code