Skip to content

cannot trim any HTTP/1.1 request code #1390

Closed

Description

@vtjnash

The _roundtrip_incoming! function calls @spawn on the body writer as a closure over write_state::Union{Nothing,_RequestWriteState} and a TCP-or-TLS stream in :h1 mode. This isn't possible to trim, since it isn't a concrete type. Claude noted there is a test for this, which doesn't get exercised fully, so it doesn't get noticed currently, as Julia's trim warnings are not implemented yet for Task so it gets missed.

Activity

  1. quinnj commented on Sep 29, 2026

    @quinnj
    Member

    Waiting for a solution to JuliaLang/julia#61499 to really advertise/fully test trimming in this package

  2. vtjnash commented on Sep 29, 2026

    @vtjnash
    MemberAuthor

    JuliaLang/julia#59221 is already merged there (though collecting invokes and warning trim errors aren't fixed yet there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions