Repository navigation
Conversation
quinnj
marked this pull request as ready for review
October 8, 2026 18:52
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1397 +/- ##
==========================================
+ Coverage 90.80% 90.83% +0.02%
==========================================
Files 31 31
Lines 12835 12881 +46
==========================================
+ Hits 11655 11700 +45
- Misses 1180 1181 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
`servecontent` over a byte vector answers a Range request with a `BytesBody` over a contiguous view. Strict mode rejected that body type, so a natively built server answered byte-range requests (video seeking) with a 500. Add it to the strict body set and cover it in the native router workload. Default builds now skip the narrowing entirely and dispatch exactly as before. Build the handler C entrypoint with a plain `@cfunction` over the callable's type instead of a generated function and wrapper struct, and shorten the native-build guide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep one narrowing path for both modes so the whole suite exercises the strict body set; strict mode only adds the final throw. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native applications that use
HTTP.Routerfail JuliaC's--trim=safeverifier on HTTP 2.9. Route registration and the route trie erase handler types, routed handlers return responses whose body type is unknown, and HTTP/2 shutdown calls an erasedFunction. LeagueEasy's production build reported 48 verifier errors; the new standalone router workload reproduced 15 before this change.Changes
trim_strict_bodiespreference. With it enabled:servecontentbyte ranges over a byte vector) are the only ones accepted; the server answers other body types with a 500;Tests
servecontentresponse, 404/405, shutdown) must compile with zero verifier errors.Validation
Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex and Claude Code.
🤖 Generated with Claude Code