Repository navigation
Conversation
…+uppercase pwcc hashes Client-config (pwcc) files stored by SEB can be encrypted with an empty container password. Also SEB uses SHA-256 hex lowercase for pwcc hashing but some tools produce uppercase. Try empty password first for pwcc (no prompt); for user-supplied pwcc passwords, try lowercase (SEB standard) then uppercase as fallback. Fixes loading of: - SebClientSettings-*.seb (official client settings) - examples/maconf.seb - preserve compatibility for truly password-protected files.
Owner
|
I might just take this change and do the change local myself because I currently got alot of code locally that will conflict this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Client-config (
pwcc) files can be stored with an empty container password (SEB stores unprotected client configs aspwccwithPassword="", IsHash=true). The app forced a prompt and hashed the input, so these files failed to load. Also, for password-protectedpwcc, SEB hashes to lowercase hex; some tools emit uppercase.Fix
In
src/settings/password_container.cpp::unwrapSebContainer():pwcc, try the empty password first (no prompt). If it decrypts, proceed.pwccpasswords, try lowercase SHA-256 hex first (SEB standard), then fall back to uppercase for compatibility.pswdbehavior unchanged.Verification
SebClientSettings-*.sebandexamples/maconf.sebnow load without requiring the admin/file password (container is empty).pwccfiles still require the correct password; wrong passwords are rejected.This matches SEB's behavior (old Config Tool tries empty for
pwcc; new SEB stores client configs with empty password).