Extend Cloud Build configuration to run tests on push and merge#1097
Open
stevemessick wants to merge 5 commits into
Open
Extend Cloud Build configuration to run tests on push and merge#1097stevemessick wants to merge 5 commits into
stevemessick wants to merge 5 commits into
Conversation
- Run unit tests and linting on Python 3.11 and 3.12. - Run integration tests on Python 3.11 and 3.12 only on merge to main. - Mark test_get_apikey_creds_invalid_json as expected failure due to old kagglesdk. TAG=agy CONV=0ac92854-39e9-433e-a61b-52fb995a144a
TAG=agy CONV=7cc886bc-7293-4f57-a398-5d4a69a9a91e
TAG=agy CONV=7cc886bc-7293-4f57-a398-5d4a69a9a91e
rosbo
requested changes
Jul 13, 2026
| # Check substitutions / Pull cache for MIN | ||
| - name: 'gcr.io/cloud-builders/docker' | ||
| id: 'check_substitutions' | ||
| id: 'check_substitutions_min' |
Contributor
There was a problem hiding this comment.
Instead of running against min and max, we should configure separate triggers to run the pipeline against a list of different python versions.
This is how we do it for kagglehub: https://github.com/Kaggle/kaggleazure/blob/cd6d6b258fb1dddc90f29b5995d421acf5213828/configs/cicd/cloud_builds/main.tf#L2019
It is also nice because you can easily see on github which python version failed (see screenshot) and use docker-hatch with the --python-version flag to debug locally.
Address review comment: configure separate triggers to run the pipeline against different python versions instead of duplicating steps in a single workflow. TAG=agy CONV=37f1c9b9-ac6f-4e29-874d-c083460c7db1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TAG=agy
CONV=0ac92854-39e9-433e-a61b-52fb995a144a