Repository navigation
feat(ecs): add stable host and agent identity to alerts - #734
Merged
Merged
Conversation
Stamp host.id, host.name, agent.id, agent.type and agent.version on every live alert in both the NDJSON file and webhook bodies. Identity resolves once at startup; agent.id persists owner-only under the new agent.directory. Undeterminable ids are omitted, and replay carries no identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #730
What
Live alerts (Sigma, YARA, IOC, correlation, dedup rollups) now carry
host.id,host.name,agent.id,agent.type,agent.version, identically in the NDJSON file and webhook bodies.How
identitymodule, resolved once at startup and attached toAlertSink;write_ecsis the single serialization point, so there is no per-event lookup.host.id: keyed one-way digest of the OS machine id (/etc/machine-id, macOSkern.uuid, WindowsMachineGuid); raw id is never emitted. Empty/zero/uninitializedids are omitted.host.name: trimmed, lowercased hostname.agent.id: random UUID persisted owner-only in<agent.directory>/agent-id(new[agent] directoryoption, managed layouts use astatedir). If it cannot be persisted it is omitted rather than invented.docs/output.md(including cloning/image guidance), generateddocs/configuration.md.Tests
Unit tests (id derivation, normalization, persistence, permissions, reinstall, corrupt file, unwritable dir),
tests/alert_identity.rs(rollups, omission, stability), webhook/file parity, ECS contract for replay mapping.Not verified
The Windows
MachineGuidreader was not compiled locally (no Windows target installed on this Mac); worth a CI/lab-windows check. Heartbeat (#557) can reuseIdentity.