V2 by KiraLT · Pull Request #164 · KiraLT/common-stuff

KiraLT · 2025-09-15T16:26:25Z

No description provided.

BREAKING CHANGE: drop CommonJS support, only ESM module is released

…ipt configuration

Copilot

Pull Request Overview

This pull request represents a major migration from V1 to V2 of the library, introducing comprehensive changes to improve the development experience, modernize tooling, and add new functionality.

Migration from Jest to Node.js native test runner with built-in coverage support
Complete replacement of build tooling from Microbundle to TypeScript compiler with explicit file extensions
Addition of new iterable module with universal reduce function and new outdent template literal function

Reviewed Changes

Copilot reviewed 36 out of 39 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
package.json	Updated build tooling, test setup, and dependencies for V2 migration
biome.json	Added Biome for code formatting and linting
src/iterable.ts	New module with universal reduce function for sync/async iterables
src/string.ts	Added outdent function for removing leading indentation from template literals
src/guards.ts	Enhanced with new type guards and updated to use modern JavaScript methods
spec/*.spec.ts	Migrated all tests from Jest to Node.js native test runner
src/*.ts	Updated import statements to use explicit .ts file extensions

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-23T10:26:15Z

+ * @param strings
+ * @param values
+ * @returns


The JSDoc parameters lack descriptions. Add proper descriptions for strings (TemplateStringsArray), values (interpolated values), and @returns (processed string with indentation removed).

Suggested change

* @param strings

* @param values

* @returns

* @param strings The array of string literals from the template (TemplateStringsArray).

* @param values The interpolated values within the template.

* @returns The processed string with indentation removed.

Copilot · 2025-09-23T10:26:15Z

        const numKey = parseInt(key.toString(), 10)

-        return isNaN(numKey)
+        return Number.isNaN(numKey)


[nitpick] Good improvement replacing the global isNaN with Number.isNaN which provides more precise NaN checking without type coercion.

Copilot · 2025-09-23T10:26:15Z

 export function ensureArray<T>(value: T | T[]): T[]
 export function ensureArray<T>(value: T | ReadonlyArray<T>): ReadonlyArray<T>
 export function ensureArray<T>(value: T | readonly T[]): ReadonlyArray<T> {
-    return value instanceof Array ? value : [value]
+    return Array.isArray(value) ? value : [value as T]


The type assertion as T could potentially mask type errors. Consider using a more explicit type guard or ensuring the generic constraint is properly defined to avoid unsafe casting.

Copilot · 2025-09-23T10:26:16Z

-    T extends unknown,
-    Key extends string | number | symbol,
->(
+export function hasKeys<T, Key extends string | number | symbol>(


[nitpick] Good simplification of the generic constraint from T extends unknown to just T, which is more concise and equally effective.

Copilot · 2025-09-23T10:26:16Z

@@ -9,343 +9,343 @@
 *
 * @group Http


Converting from enum to const objects is a breaking change that affects how these values are imported and used. Consider documenting this breaking change and providing migration guidance for users upgrading from V1.

Suggested change

* @group Http

* @group Http

*

* @remarks

* **Breaking Change in V2:** `HttpStatusCodes` was previously exported as a TypeScript `enum` in V1. It is now exported as a `const` object.

* - **Migration:** Update your imports and usage from `import { HttpStatusCodes } from ...` and `HttpStatusCodes.ACCEPTED` to the same property access, but note that reverse mapping (e.g., `HttpStatusCodes[202]`) is no longer supported.

* - If you relied on enum-specific features, refactor your code to use the object properties directly.

Copilot · 2025-09-23T10:26:16Z

+export const HttpStatusReasons = {
    /**


Converting from enum to const objects is a breaking change that affects how these values are imported and used. Consider documenting this breaking change and providing migration guidance for users upgrading from V1.

Suggested change

export const HttpStatusReasons = {

/**

Copilot · 2025-09-23T10:26:16Z

+ * @param compare find calls predicate once for each element of the array, in ascending
 * order, until it finds one where predicate returns true. If such an element is found,


The parameter name in the documentation (compare) doesn't match the actual parameter name in the function signature. This should be consistent with the implementation.

Suggested change

* @param compare find calls predicate once for each element of the array, in ascending

* order, until it finds one where predicate returns true. If such an element is found,

* @param compare `compare` is called once for each element of the array, in ascending

* order, until it returns true. If such an element is found,

…o false

BREAKING CHANGE: removed UMD support and simplified bundling to output pure TSC output. Overall API did not change.

+                writable: true,
+            })
+            try {
+                const uuid = generateUUID()


# [2.0.0](v1.11.2...v2.0.0) (2026-07-20) * V2 ([#164](#164)) ([9deba7e](9deba7e)) ### BREAKING CHANGES * * ESM-only. CJS/UMD entry points removed; require("common-stuff") no longer works. httpErrorHandler removed — inline the middleware (it was a thin instanceof HttpError wrapper). * HttpStatusCodes / HttpStatusReasons are const objects, not enums (required by erasableSyntaxOnly). Value reads are unchanged; the type HttpStatusCodes is gone — use (typeof HttpStatusCodes)[keyof typeof HttpStatusCodes] if needed. * Array-only flatMap removed. The universal flatMap (iterable module) requires callbacks to return an iterable and only passes (item, index). * parseSize returns number | undefined instead of -1. * merge<A, B>(target, source): A & B — return type is inferred. Explicit merge<MyShape>(a, b) calls need to pass both generics or cast. * hashCode integers changed (prefixed with typeof to avoid falsy collisions). Invalidate any persisted hashes. * difference / intersection / union / shuffle now correctly return T[] for mutable inputs (v1 always returned ReadonlyArray<T> due to overload order). * isArray narrows readonly inputs to ReadonlyArray<T> (v1 narrowed them to mutable Array<T>); runtime switched to * * Array.isArray (fixes cross-realm). * getByKey infers the return type from literal paths. Pass T explicitly for dynamic paths.

github-actions · 2026-07-20T10:05:34Z

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

KiraLT added 2 commits September 15, 2025 19:25

feat: remove custom bundling and jest in favor of tsc and node test

30bdcd3

BREAKING CHANGE: drop CommonJS support, only ESM module is released

chore: update test command to use coverage script

33bb726

KiraLT linked an issue Sep 15, 2025 that may be closed by this pull request

Universal helpers for all iterable data structures #37

Closed

17 tasks

KiraLT added 4 commits September 15, 2025 19:28

chore: remove build dependency from release job

074fb9b

feat: universal reduce function

8e94a57

chore: Refactor imports to include file extensions and update TypeScr…

0cc82a6

…ipt configuration

chore: Remove tsx

821d0e9

Copilot AI review requested due to automatic review settings September 23, 2025 10:24

Copilot AI reviewed Sep 23, 2025

View reviewed changes

KiraLT added 8 commits September 26, 2025 14:24

feat: update ts config

e813a89

chore: update package.json to use exports field and set sideEffects t…

a54d281

…o false

feat: new iterable helpers

6d6fc70

fix: multiple fixes and improvements

4f7982b

feat: More helpers

14e52b7

BREAKING CHANGE: removed UMD support and simplified bundling to output pure TSC output. Overall API did not change.

chore: more tests and overall improvements

43ba342

Readme update

992c61b

Improvements

e3b4602

github-advanced-security Bot found potential problems May 23, 2026

View reviewed changes

Comment thread spec/encoding.spec.ts

writable: true,

})

try {

const uuid = generateUUID()

KiraLT merged commit 9deba7e into main Jul 20, 2026
4 of 5 checks passed

github-actions Bot added the released label Jul 20, 2026

Navigation Menu

V2 - #164

V2#164
KiraLT merged 14 commits into
mainfrom
v2

KiraLT commented Sep 15, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 23, 2025

Uh oh!

Copilot AI Sep 23, 2025

Uh oh!

Copilot AI Sep 23, 2025

Uh oh!

Copilot AI Sep 23, 2025

Uh oh!

Copilot AI Sep 23, 2025

Uh oh!

Copilot AI Sep 23, 2025

Uh oh!

Copilot AI Sep 23, 2025

Uh oh!

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

- * @group Http
+ * @group Http
+ *
+ * @remarks
+ * **Breaking Change in V2:** `HttpStatusCodes` was previously exported as a TypeScript `enum` in V1. It is now exported as a `const` object.
+ * - **Migration:** Update your imports and usage from `import { HttpStatusCodes } from ...` and `HttpStatusCodes.ACCEPTED` to the same property access, but note that reverse mapping (e.g., `HttpStatusCodes[202]`) is no longer supported.
+ * - If you relied on enum-specific features, refactor your code to use the object properties directly.

		* @param compare find calls predicate once for each element of the array, in ascending
		* order, until it finds one where predicate returns true. If such an element is found,

Conversation

KiraLT commented Sep 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants