Skip to content

Match club navbar buttons to hero style#476

Merged
Adr1an04 merged 1 commit into
mainfrom
club/navbar-square-buttons
Jun 26, 2026
Merged

Match club navbar buttons to hero style#476
Adr1an04 merged 1 commit into
mainfrom
club/navbar-square-buttons

Conversation

@DVidal1205

@DVidal1205 DVidal1205 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • updates the club site navbar CTA buttons to match the hero CTA treatment
  • keeps square corners, black borders, shine/press interactions, and the offset shadow/underline piece on both desktop and mobile menu CTAs

Verification

  • pnpm --filter @forge/club format
  • pnpm --filter @forge/club lint
  • mobile confirmed: the mobile menu uses the same ActionLinks component/classes as desktop, with no mobile override removing the square/offset-shadow treatment

Screenshot

Desktop verification screenshot captured locally and shared in Discord.

Summary by CodeRabbit

  • Style
    • Updated navigation action buttons with a bolder, more modern look: sharper corners, stronger borders, adjusted spacing, and smoother motion effects.
    • Added a subtle hover sheen and refined hover/active feedback for a more polished interactive feel.
    • Refreshing primary and secondary button variants with clearer visual contrast and more consistent styling.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 59eda709-ccdc-4c17-b193-ace1069506d5

📥 Commits

Reviewing files that changed from the base of the PR and between dc7b099 and ae7952a.

📒 Files selected for processing (1)
  • apps/club/src/app/globals.css

📝 Walkthrough

Walkthrough

The PR rewrites .club-nav-action styling in globals.css, changing the base button shape and transitions, adding a hover sheen effect, and updating the primary and secondary variants to fixed color and shadow treatments.

Changes

Club nav action styling

Layer / File(s) Summary
Base shell
apps/club/src/app/globals.css
.club-nav-action gets thicker borders, square corners, adjusted spacing, overflow isolation, and expanded transition properties.
Sheen and motion
apps/club/src/app/globals.css
.club-nav-action::before adds a diagonal sheen overlay, and hover/active states now translate and shift saturation.
Primary and secondary variants
apps/club/src/app/globals.css
.club-nav-action-primary and .club-nav-action-secondary switch to fixed gold/dark palettes with persistent shadows and updated hover behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

Feature, Minor

🚥 Pre-merge checks | ✅ 7 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes the change, but it does not start with an issue number in brackets as required. Prefix the title with an issue key like "[#123]" and keep the description concise, e.g. "[#123] Match club navbar buttons to hero style".
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Hardcoded Secrets ✅ Passed Changed CSS has no secret-like literals; repo scan only hit a docs example and a token field name, while real secrets come from env.
Validated Env Access ✅ Passed PR only changes apps/club/src/app/globals.css and introduces no process.env usage, so no raw env access was added.
No Typescript Escape Hatches ✅ Passed The club subtree shows no any, @ts-ignore, @ts-expect-error, or non-null assertions; this PR’s change is CSS-only.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch club/navbar-square-buttons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Adr1an04 Adr1an04 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome lenny

@Adr1an04 Adr1an04 added this pull request to the merge queue Jun 26, 2026
Merged via the queue into main with commit c2f9fc5 Jun 26, 2026
11 checks passed
@Adr1an04 Adr1an04 deleted the club/navbar-square-buttons branch June 26, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants