feat: bigger footer built-by mark above the copyright - #4
Merged
Merged
Conversation
BuiltByMark gains a markClass prop for the artwork (default h-10 w-auto, matching the brand docs footer) applied to both the rendered SVG and an image override. Footer moves the copyright into the identity column directly below the mark: identity, mark, copyright.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuiltByMarkgainsmarkClass?: stringfor the artwork, defaulting toh-10 w-auto(40 px, matching the brand docs footer), applied to both the rendered brand SVG and abuiltBy.markimage override. The existingclassstill targets the<a>wrapper.Footermoves the copyright line out of its standalone grid cell and into the identity<aside>, directly below the mark. Order is now identity lockup → tagline → built-by mark (mt-5) → copyright (mt-3 text-xs). The mark is still always rendered.[Unreleased]updated.Changelog
Changed
BuiltByMarkdefaults the artwork toh-10 w-auto(40 px, matching the brand docs footer) via the newmarkClassprop, andFootermoves the copyright into the identity column directly below the mark: identity → mark → copyright.Verification
pnpm test(66 passed),pnpm typecheck,pnpm build.