fix: keep the initial K in the footer built-by mark - #6
Merged
Merged
Conversation
BuiltByMark used renderBrandMark, whose legacy builtByMark variant map omits the icon mark, so the footer wordmark rendered without the initial K. Render the generated per-variant content via renderBrandVariant instead, mirroring Mark.astro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuiltByMark.astrorendered the footer wordmark with the legacyrenderBrandMark({ variant: 'builtByMark' }), whose stale variant map omitsiconMark(the initial K) — the footer showed "built by olektiv computing"(23 paths, no
id="icon_mark").Render the generated per-variant content with
renderBrandVariant('builtByMark', {…})instead, mirroringMark.astro.The legacy bug is being fixed in brand-core separately; chrome no longer
depends on that fix. The
@kolektiv/brand-corerange stays^0.1.0.Verification
pnpm test— 66 passed;pnpm typecheckclean;pnpm buildclean;playground build clean.
<svg>: 24 paths,id="icon_mark"present(before: 23 paths, no
icon_mark). Only the footer built-by SVG changedbetween playground builds; no CSS asset changes.
Fixed
used instead of the legacy partial map.