Skip to content

Update testGetSignalDataResourceContainerScoping to use the correct user permission and params #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-tchad merged 1 commit into from
Jun 20, 2026
Merged

Update testGetSignalDataResourceContainerScoping to use the correct user permission and params #1029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions signalData/src/org/labkey/signaldata/SignalDataController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,9 @@
import org.labkey.api.security.permissions.AbstractContainerScopingTest;
import org.labkey.api.security.permissions.ReadPermission;
import org.labkey.api.security.permissions.UpdatePermission;
import org.labkey.api.security.roles.ReaderRole;
import org.labkey.api.security.roles.EditorRole;
import org.labkey.api.util.FileUtil;
import org.labkey.api.util.Path;
import org.labkey.api.util.UnexpectedException;
import org.labkey.api.view.ActionURL;
import org.labkey.api.webdav.WebdavResource;
import org.labkey.api.webdav.WebdavService;
Expand Down Expand Up @@ -247,7 +246,7 @@ public void setup() throws Exception
{
_folderA = createContainer("A");
_folderB = createContainer("B");
_readerA = createUserInRole(_folderA, ReaderRole.class);
_readerA = createUserInRole(_folderA, EditorRole.class);
}

@Test
Expand Down Expand Up @@ -283,10 +282,10 @@ public void testGetSignalDataResourceContainerScoping() throws Exception
*/
private static ActionURL resourceUrl(Container requestContainer, Container fileContainer, String name)
{
String path = filesPath(fileContainer).append(name).toString();
String[] paths = { filesPath(fileContainer).append(name).toString() };
String[] files = { name };
return new ActionURL(getSignalDataResourceAction.class, requestContainer)
.addParameter("path", path)
.addParameter("test", true);
.addParameters(Map.of("paths", paths, "files", files));
}

private static Path filesPath(Container c)
Expand Down