Scope ONPRC billing run deletion to the current container#1767
Open
labkey-martyp wants to merge 2 commits into
Open
Scope ONPRC billing run deletion to the current container#1767labkey-martyp wants to merge 2 commits into
labkey-martyp wants to merge 2 commits into
Conversation
deleteBillingRuns built SimpleFilters over the raw onprc_billing tables (invoicedItems, invoiceRuns, miscCharges) from request-supplied primary keys with no container predicate, and received no Container, so a billing admin in one folder could delete or detach billing rows in any other folder by POSTing arbitrary object IDs. Add a Container parameter and confine every read, delete, and update to the caller's folder: invoiceRuns and invoicedItems get a direct container filter, and miscCharges is keyed off the container-authorized run ids. Add ONPRC_BillingManager.TestCase covering cross-container isolation and register it in getIntegrationTests(). 26.3 port of #1759.
The Module interface changed getIntegrationTests() to return Set<Class<?>> instead of the raw Set<Class>, breaking the override in ONPRC_BillingModule. Update the override signature to match.
Collaborator
|
@labkey-martyp, Gary installed and checked the PR and it appears to run as expected. He's going to ask Sally, our finance person, to test it. Once we get approval, we'd still like to delay the squash and merge until after our month-end billing. Monday, July 6, would be a good day. Please let us know if this causes any issues. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
ONPRC_BillingManager.deleteBillingRuns built SimpleFilters over the raw onprc_billing tables (invoicedItems, invoiceRuns, miscCharges) from request-supplied primary keys with no container predicate, and the method received no Container. Since DeleteBillingPeriodAction's permission check is evaluated only against the current folder, a billing admin in one folder could delete or detach billing rows belonging to any other folder by POSTing arbitrary object IDs - a cross-container horizontal privilege-escalation bug. This change confines every operation to the caller's folder. This is the 26.3 port of #1759 (originally against release25.7-SNAPSHOT).
Related Pull Requests
Changes
Container filters added on
All tables are in the onprc_billing schema: