Repository navigation
test(middleware): cover validation middleware error shape and nested schema contracts - #2213
Open
DeepDev69x3 wants to merge 1 commit into
Open
DeepDev69x3 wants to merge 1 commit into
DeepDev69x3 wants to merge 1 commit into
Conversation
Malware detection scan flagged this pull requestThe scan found 1 indicator(s) in the PR diff. This PR is blocked until a maintainer reviews the flagged files.
This is an automated triage signal; maintainers must verify whether the finding is malicious or intentional. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Closes #2095
Adds comprehensive deterministic unit and integration test coverage for Express request validation middleware in
backend/src/middleware/validation.ts, ensuring robust handling of nested schemas, boundary inputs, and consistent 400 response contracts when passed through centralizederrorHandler.Detailed Test Coverage
validateBody:next()with no arguments on valid payloads.z.ZodError.nested.details.verified) emitting correct dot-delimited error paths.tags.1) in structured payloads.undefined/ empty body) safely without throwing uncaught exceptions.validateQuery&validateParams:page,limit) and enum validation for query filters.loanId).validate&createSchemaHelpers:createSchema.body,createSchema.query,createSchema.params).Integration with
errorHandler(Consistent 400 Contract):success: false,message: 'Validation failed',errors: [{ path, message }]`).error.code === 'VALIDATION_ERROR',error.fieldset to first failing field, anderror.detailscontaining complete{ field, message, code }` objects).Verification
npm test -- src/middleware/__tests__/validation.test.ts: 15/15 tests passed (100% green).npm test: 126/126 test suites passed, 1087/1087 tests passed (0 failed).npm run build:tsc -p tsconfig.build.jsonsucceeded with 0 errors.