Repository navigation
test(middleware): cover pause guard state races, concurrent toggles, and route boundaries - #2219
Open
hubbuugittuuu wants to merge 1 commit into
Open
hubbuugittuuu wants to merge 1 commit into
hubbuugittuuu wants to merge 1 commit into
Conversation
…and route boundaries
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive unit and regression test coverage for
pauseGuardmiddleware inbackend/src/middleware/__tests__/pauseGuard.test.ts, addressing concurrent pause state transitions, mid-flight loan mutation races, and exempt route boundary rules.Closes #2093
Details of Changes
setPauseStatepreserve valid in-memory state without race condition corruptions./api/loans/disburse) with 503AppError./api/loans/repay) are permitted through tonext().reasonis null or omitted, verifyingMaintenance or security measuredefault.pauseGuardfails open gracefully and preserves existing in-memory state./api/auth/login,/api/v1/auth/session,/api/admin/recovery,/api/v1/admin/unpause,/admin/status)./api/authentication/login,/api/administrator/kill,/api/loans/repay,/api/v1/loans/apply,/api/contracts/invoke) remain strictly blocked during an active pause.Verification & CI Proof
npm run lint: Passed (0 errors)npm run build: Passed (0 errors)npm test -- src/middleware/__tests__/pauseGuard.test.ts: 28/28 tests passing (100% green)