Skip to content

When setting unobserved caribou years for recruitment assume month is end of cairbou year not start - #113

Draft
see24 wants to merge 2 commits into
mainfrom
dev
Draft

see24 wants to merge 2 commits into
mainfrom
dev

Conversation

@see24

@see24 see24 commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

When combining observed and simulated caribou surveys we found we were having trouble with the conversion from years to caribou years which created gaps in the data. I think that it makes the most sense that when there are missing values in recruitment data and the month is NA, which is required, we assume the month of the recruitment survey is year_start - 1 so that it comes at the end of the caribou year. So by default that would mean if the Year is 2023 and month is NA we assume the month is 3 and therefore the caribou year will come out as 2022.

I have run tests locally and they pass after updating snapshots and modifying one expectation to match the change.

See also: LandSciTech/caribouMetrics#169

Sarah Endicott added 2 commits October 22, 2026 09:44
… month is end of cairbou year not start."

This reverts commit 445ec22.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant