Repository navigation
Conversation
added 2 commits
October 22, 2026 09:44
… month is end of cairbou year not start." This reverts commit 445ec22.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When combining observed and simulated caribou surveys we found we were having trouble with the conversion from years to caribou years which created gaps in the data. I think that it makes the most sense that when there are missing values in recruitment data and the month is NA, which is required, we assume the month of the recruitment survey is year_start - 1 so that it comes at the end of the caribou year. So by default that would mean if the Year is 2023 and month is NA we assume the month is 3 and therefore the caribou year will come out as 2022.
I have run tests locally and they pass after updating snapshots and modifying one expectation to match the change.
See also: LandSciTech/caribouMetrics#169