Skip to content

fix(dag): ReviewGateError message hardcodes "deep workflow" for all modes #305

Closed

Description

@LeXwDeX

Discovered by live testing on v1.0.21: calling control(complete) on a standard-mode workflow with an unresolved review returns:

Cannot complete deep workflow dag_...: unresolved review outcome(s): decision

The gate behavior is correct; only the wording is wrong — the message should name the actual mode (or omit it). One-line fix in the ReviewGateError constructor message (dag.ts).

Activity

  1. added
    bugSomething isn't working
    ready-for-agentFully specified and ready for an agent
    on Aug 16, 2026
  2. LeXwDeX commented on Aug 16, 2026

    @LeXwDeX
    OwnerAuthor

    Fixed in PR #306 (dev) and promoted via PR #307; shipped in v1.0.22 (merge 9939cfa). ReviewGateError no longer claims 'deep workflow' for all modes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions