fix: order thinking variants and prepare v1.0.62 - #709
Merged
Merged
Conversation
LeXwDeX
marked this pull request as ready for review
October 3, 2026 20:25
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Ctrl-T followed variant object insertion order. Merging configured low and medium variants into generated high and max variants could make the cycle run high, max, low, medium.
What changed
Order available reasoning variants after the final provider configuration merge and disabled-variant filter. The TUI, app, and direct-run interface now receive known effort names in increasing order. Existing parameters, saved selections, and the default-mode cycle remain intact. Include the v1.0.62 release notes.
Closes #708
Evidence
The regression reproduced the old order before the fix. The release checkout passed 486 focused provider, transform, variant, boot, and release-helper tests. All 31 workspace typecheck tasks passed. Lint passed its unchanged 4850-warning limit with 4834 warnings and no errors. Formatting and release-note rendering passed.
An isolated source TUI completed 11 Ctrl-T steps from default through the available variants and back to default. Screen labels and persisted selections matched at every step. The app cycle tests passed (7 tests). Direct footer rendering, layout, and menu tests passed (27 tests, 5 existing skips). The test created no sessions or messages and left no running process. Astra reviewed the final five-file patch.
Native CI passed on PR head
6cf7909: Typecheck and Linux unit tests plus Linux/Windows E2E. The unit job also passed the Go tests, both client generation checks, and HTTP API gates.Typecheck attempt 1 hit the existing 3-second schema-validation subprocess watchdog. The 14 schema-budget tests passed once locally with coverage, and the complete Typecheck job passed unchanged on attempt 2. No tests or timeout limits were changed.
Checklist