feat(wad): admit entry counts below TOC capacity - #266
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WadTailLayout::admits_entry_countaccepts any count<= toc_capacity. The lower bound (capacity - TOC_SLACK_ENTRIES, with the constant at 0) is removed along with the constant. The slack is set by the writer of the file (ltk_overlay).The client reads
chunk_countTOC entries and ignores the zeroed slots between the last entry and the first data byte. Verified in game with 16384 reserved slots: fresh build, in-place entry add, in-place entry removal.Tests: count admission up to capacity, and a dropped entry leaving a zeroed slot that mounts.