Repository navigation
DO NOT MERGE ritobin fixes - #269
Open
moonshadow565 wants to merge 3 commits into
Open
moonshadow565 wants to merge 3 commits into
moonshadow565 wants to merge 3 commits into
Conversation
Crauzer
requested changes
Oct 2, 2026
| /// | ||
| /// The canonical text is stable: a value prints as the same bytes in every release, and a change | ||
| /// to it is a breaking change. | ||
| pub trait PrintCanonical { |
Member
There was a problem hiding this comment.
Can this instead be refactored into a generalized PrintConfig trait and we provide a canonical (prettified) printer with indentation set to 4 and any other knobs/toggles.
Contributor
Author
There was a problem hiding this comment.
That would be what Print already does, i do not want to introduce any breaking changes there.
Any configurability can be added and adjusted there instead, the purpose of canonical printer is that it outputs stable reproducible output.
Contributor
Author
|
fixes should be pulled out from this and stable/canonical printing is going to be done by @alanpq one day ™️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.