Skip to content

Add sender and protocol metadata to frames; refactor result types - #2

Merged
Lefix2 merged 2 commits into
masterfrom
claude/lla-hla-export-refinements-xc3X4
May 22, 2026
Merged

Lefix2 merged 2 commits into
masterfrom
claude/lla-hla-export-refinements-xc3X4

Conversation

@Lefix2

@Lefix2 Lefix2 commented May 22, 2026

Copy link
Copy Markdown
Owner

Summary

This PR enhances frame metadata by adding sender (card/reader) and protocol (T0/T1) fields to all TPDU and APDU frames, and simplifies the result type definitions by removing T1-specific frame types in favor of unified TPDU/APDU types.

Key Changes

  • Unified frame types: Removed t1_block and t1_apdu result types; T1 protocol frames now use tpdu and apdu types with a protocol field to distinguish T0 from T1
  • Added metadata fields: All TPDU and APDU frames now include:
    • sender: "card" or "reader" to indicate frame direction
    • protocol: "T0" or "T1" to indicate protocol version
  • Simplified descriptions: Removed sender prefix from frame descriptions (e.g., "reader I(NS=0,M=1)..." → "I(NS=0,M=1)...") since sender is now a separate metadata field
  • ATR frame enhancement: Added sender: 'card' metadata to ATR frames
  • PPS frame enhancement: Added sender metadata to PPS frames; removed sender from description text
  • Export file update: Modified CSV export to include a "Sender" column and filter for character-level nodes only
  • Version bump: Updated extension version from 1.1.1 to 1.2.0
  • Description update: Clarified extension description to mention HLA/LLA relationship and frame types

Implementation Details

  • Frame metadata is now consistently passed via the AnalyzerFrame data dictionary
  • T1 block descriptions no longer include sender prefix; sender is conveyed via the sender field
  • Export functionality now properly extracts sender information from ISO7816NodeChar objects and includes it in the CSV output
  • All protocol-level frames (ATR, PPS, TPDU, APDU) maintain consistent metadata structure for downstream consumers

https://claude.ai/code/session_01ANMPz4wDUwyzd1hRe3scFq

claude added 2 commits May 22, 2026 08:02
HLA: sender column, keep atr/pps/tpdu/apdu types only, version 1.2.0

- LLA GenerateExportFile: look up node to get actual mCharVal (was always
  0 because frame.mData1 was never set); add Sender column
- HLA result_types: remove t1_block/t1_apdu; rename to tpdu/apdu
- HLA frames: strip reader/card from description strings; add dedicated
  sender key to every emitted frame (atr, pps, tpdu, apdu)
- extension.json: remove GitHub URL, concise LLA+HLA dependency note,
  version 1.2.0

https://claude.ai/code/session_01ANMPz4wDUwyzd1hRe3scFq
@Lefix2
Lefix2 merged commit 129a1cd into master May 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants