Repository navigation
Add sender and protocol metadata to frames; refactor result types - #2
Merged
Merged
Conversation
HLA: sender column, keep atr/pps/tpdu/apdu types only, version 1.2.0 - LLA GenerateExportFile: look up node to get actual mCharVal (was always 0 because frame.mData1 was never set); add Sender column - HLA result_types: remove t1_block/t1_apdu; rename to tpdu/apdu - HLA frames: strip reader/card from description strings; add dedicated sender key to every emitted frame (atr, pps, tpdu, apdu) - extension.json: remove GitHub URL, concise LLA+HLA dependency note, version 1.2.0 https://claude.ai/code/session_01ANMPz4wDUwyzd1hRe3scFq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances frame metadata by adding
sender(card/reader) andprotocol(T0/T1) fields to all TPDU and APDU frames, and simplifies the result type definitions by removing T1-specific frame types in favor of unified TPDU/APDU types.Key Changes
t1_blockandt1_apduresult types; T1 protocol frames now usetpduandapdutypes with aprotocolfield to distinguish T0 from T1sender: "card" or "reader" to indicate frame directionprotocol: "T0" or "T1" to indicate protocol versionsender: 'card'metadata to ATR framessendermetadata to PPS frames; removed sender from description textImplementation Details
AnalyzerFramedata dictionarysenderfieldISO7816NodeCharobjects and includes it in the CSV outputhttps://claude.ai/code/session_01ANMPz4wDUwyzd1hRe3scFq