Pre-Flight checklist
Describe The Feature Request Below
On many of the screens, we pass in large view models, which let you refetch and update data. For example, we pass in the siteViewModel, appSettingsViewModel, and accountViewModel into screens where it shouldn't need to write or update those objects, only read them.
This isn't ideal because:
- It exposes the objects within as writeable, where many shouldn't be.
- We then have to
observeAsState, whereas in most cases we should only need to have the GetSiteResponse or AppSettings
We should go through every screen in MainActivity.kt, and make sure its only passing the minimum of what it needs.
Pre-Flight checklist
Describe The Feature Request Below
On many of the screens, we pass in large view models, which let you refetch and update data. For example, we pass in the
siteViewModel,appSettingsViewModel, andaccountViewModelinto screens where it shouldn't need to write or update those objects, only read them.This isn't ideal because:
observeAsState, whereas in most cases we should only need to have theGetSiteResponseorAppSettingsWe should go through every screen in
MainActivity.kt, and make sure its only passing the minimum of what it needs.