Repository navigation
[7/7] Add optional notes to username EVM payments - #1740
Merged
Merged
Conversation
dnlbui
marked this pull request as ready for review
October 2, 2026 17:54
dnlbui
added this pull request to stack #1741
October 2, 2026 17:54
osyed
force-pushed
the
feat/1717-7-payment-note
branch
4 times, most recently
from
October 2, 2026 18:09
f0157cd to
07e8129
Compare
* Add optional notes to username EVM payments * Restore payment notes when reviewing reverted transfers * Clarify note restoration after local contact lookup
dnlbui
force-pushed
the
feat/1717-7-payment-note
branch
from
October 2, 2026 18:14
07e8129 to
f39ee2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Show the optional note field for eligible saved-contact usernames. Enforce the 1,000-byte UTF-8 limit, show the captured note in confirmation, and carry it in encrypted announcements and payment cards.
Fixed Flow
Resolve a saved contact → optionally enter a note → review it in confirmation → preserve it through announcement synchronization and eligible retries. Clear it on recipient changes and hide it for raw addresses.
Why
Users can explain a payment within its encrypted announcement without changing EVM calldata or the asset transaction hash.
Validation
node --input-type=module --check < app.jsandnode --input-type=module --check < evm-assets.jspassed at each reconstructed phase.Stack
Part of #1717; recreates #1724 using the original branch name. Phases 2–6 (#1735–#1739) are now merged into
main. This PR targetsmainand contains only the phase 7 note commit.Rebased after phase 6's squash merge.
git range-diffconfirms the note patch is unchanged, and the complete file tree is identical to the pre-rebase branch. JavaScript syntax, diff whitespace, andnode --experimental-default-type=module --test tests/evm-assets.test.mjs tests/evm-assets-loading.test.mjs tests/contextual-evm-modal.test.mjschecks passed after rebasing.The USD-fee draft #1733 remains separate.